Closed
Bug 880137
Opened 11 years ago
Closed 11 years ago
Migrate flexbox reftests to w3c-css/submitted/ directory
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(4 files, 1 obsolete file)
1.01 KB,
patch
|
Details | Diff | Splinter Review | |
87.14 KB,
patch
|
Details | Diff | Splinter Review | |
155.74 KB,
patch
|
Details | Diff | Splinter Review | |
104.16 KB,
patch
|
Details | Diff | Splinter Review |
Filing this bug on migrating (most of) our flexbox reftests to the w3c-css/submitted/ directory, so they can be shared with w3c.
Assignee | ||
Comment 1•11 years ago
|
||
Try run with a stack of patches for this (layering on top of bug 880104): https://tbpl.mozilla.org/?tree=Try&rev=91f9137b65b6
Assignee | ||
Comment 2•11 years ago
|
||
Try run looks good. (For some reason the exact Try link in comment 1 is just loading a blank page, but I was able to load the Try TBPL front page and hit the green "down" arrow a few times & found the push's results.) Reftests are green, and I verified that tests in both the old directory & new directory are being run from skimming a reftest log.
Assignee | ||
Comment 3•11 years ago
|
||
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•11 years ago
|
||
This patch hg mv's most flexbox reftests to the w3c-css directory. This copies the resources (ahem.css & bluesquare.png) to a 'support' subdirectory, and updates the reftests that reference them, so that they can still find them.
Assignee | ||
Comment 5•11 years ago
|
||
This patch adds headers to each of the test files, for... a) <title> (currently "CSS Test: {TODO: INSERT TITLE}" in most cases*) b) <link rel="author"> with my information c) <link rel="help"> with a link to the CSS Flexbox spec. (to be further-targeted when we go through and fill in the titles with non-TODO text) d) <link rel="match"> to point to the reference case. ...and adds (a) and (b) to all of the reference files. This was a mostly-automated process (w/ "sed"), with manual filling in of the reference filenames in the <link rel="match">, and with manual filling in of the <title> in a few cases (just for flexbox-overflow-* so far) I was primarily concerned with the reference-case linkups, and I verified that those are correct by using import-tests.py to autogenerate a reftest.list file for them. I then compared that in a merge tool to the existing reftest.list, to make sure they matched.
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #5) > This patch adds headers to each of the test files, for... > a) <title> (currently "CSS Test: {TODO: INSERT TITLE}" in most cases*) [...] > c) <link rel="help"> with a link to the CSS Flexbox spec. (to be further-targeted I'll spin up one more patch to improve on these.
Assignee | ||
Comment 7•11 years ago
|
||
[dbaron granted rs=dbaron on this bug over IRC, since it's test-only and largely just file-moves & boilerplate.]
Assignee | ||
Comment 8•11 years ago
|
||
Landed, with one final patch to fill in the <title> fields and <link rel="help"> tags: https://hg.mozilla.org/integration/mozilla-inbound/rev/db8410d2f66c https://hg.mozilla.org/integration/mozilla-inbound/rev/8e82f9384070 https://hg.mozilla.org/integration/mozilla-inbound/rev/98b4083befbb https://hg.mozilla.org/integration/mozilla-inbound/rev/dd81ecba7afd
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #759320 -
Attachment is obsolete: true
Assignee | ||
Comment 10•11 years ago
|
||
For the record, here's the "part 4" patch that landed (filling in the placeholders in the boilerplate).
Tests sync'd to w3c repository, with output: remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-baseline-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-baseline-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-1-block.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-1-table.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-3-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-3.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-4-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-4.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-5-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-horiz-5.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-3-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-3.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-4-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-4.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-3-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-3.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-4-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-align-self-vert-rtl-4.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-horiz-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-horiz-1.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-vert-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-align-self-baseline-vert-1.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-empty-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-empty-1a.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-empty-1b.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-horiz-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-horiz-1.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-1.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-single-item-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-single-item-1a.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-baseline-single-item-1b.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-block-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-block-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-block-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-block-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-canvas-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-canvas-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-canvas-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-canvas-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-fieldset-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-fieldset-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-fieldset-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-fieldset-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-iframe-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-iframe-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-iframe-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-iframe-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-img-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-img-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-img-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-img-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-textarea-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-textarea-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-textarea-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-textarea-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-video-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-video-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-video-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-basic-video-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-items-as-stacking-contexts-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-items-as-stacking-contexts-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-items-as-stacking-contexts-2-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-items-as-stacking-contexts-2.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-items-as-stacking-contexts-3-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-items-as-stacking-contexts-3.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-3-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-3.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-4-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-4.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-5-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-horiz-5.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-3-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-3.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-4-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-4.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-5-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-justify-content-vert-5.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-margin-auto-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-margin-auto-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-margin-auto-horiz-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-margin-auto-horiz-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-1-reverse-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-1-reverse.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-1-rtl-reverse.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-1-rtl.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-2a.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-2b.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-3-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-3-reverse-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-3-reverse.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-3.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-4-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-mbp-horiz-4.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-horiz-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-horiz-1.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-horiz-2-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-horiz-2.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-horiz-3-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-horiz-3.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-vert-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-vert-1.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-vert-2-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-vert-2.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-vert-3-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-overflow-vert-3.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-paint-ordering-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-paint-ordering-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-paint-ordering-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-paint-ordering-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-horiz-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-horiz-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-horiz-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-horiz-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-vert-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-vert-1.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-vert-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-vert-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-table-fixup-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-table-fixup-1a.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-table-fixup-1b.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-1-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-1a.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-1b.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-2-ref.xhtml status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-whitespace-handling-2.xhtml status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-with-pseudo-elements-1-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-with-pseudo-elements-1.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-with-pseudo-elements-2-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-with-pseudo-elements-2.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-with-pseudo-elements-3-ref.html status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-with-pseudo-elements-3.html status changed to 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/reftest.list status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/support/ahem.css status changed to 'Submitted for Review' remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/support/solidblue.png status changed to 'Submitted for Review'
I think that's because they all need to point to TR drafts -- I think I can fix.
Landed 2 patches, which limits the problems to: remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/679350e2d699 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbb88e029c01 remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-horiz-1.xhtml status remains as 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-horiz-2.xhtml status remains as 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-vert-1.xhtml status remains as 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. remote: contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox-sizing-vert-2.xhtml status remains as 'Needs Work' due to error: remote: Not linked to a tracked specification anchor. which I'm not surewhat to do about .
Assignee | ||
Comment 14•11 years ago
|
||
> I think that's because they all need to point to TR drafts -- I think I can > fix. Gotcha. Sorry about that, & thanks for taking care of that. (FWIW I used dev links because some of the tests are checking things that aren't in the TR yet (since the TR is from ~8 months ago), so I thought it might be more kosher to link to up-to-date spec text for now and then update the links with a massive search-and-replace when the current dev text becomes TR later.) (In reply to David Baron [:dbaron] (in W3C meetings through June 11) (don't cc:, use needinfo? instead) from comment #13) > Landed 2 patches, which limits the problems to: [...] > contributors/mozilla/submitted/mozilla-central-reftests/flexbox/flexbox- > sizing-vert-2.xhtml status remains as 'Needs Work' due to error: > remote: Not linked to a tracked specification anchor. > > > which I'm not surewhat to do about . Yeah... Those are sort of testing how a flexbox behaves, in a block. So it's almost testing block layout. I think it could be construed as testing this chunk... > Determine the main size of the flex container using the rules of the > formatting context in which it participates. ...in section 9.2 (in the flex layout algorithm). I'll push a followup making them link there.
Assignee | ||
Comment 15•11 years ago
|
||
That was a quote from the dev. spec, BTW: http://dev.w3.org/csswg/css-flexbox/#line-sizing That text doesn't exist in the TR, so I just linked to the general "flex layout algorithm" section, http://www.w3.org/TR/css3-flexbox/#layout-algorithm
Assignee | ||
Comment 16•11 years ago
|
||
and the cset was: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b142eb80e40 Hopefully that leaves this in a sync-friendly state. Sorry about those issues, & thanks again for the syncing and the other followups.
I think it makes sense to use an ID from the editor's draft on the assumption that the editor's draft will migrate to TR at some point, even if that ID isn't there yet.
Comment 18•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/db8410d2f66c https://hg.mozilla.org/mozilla-central/rev/8e82f9384070 https://hg.mozilla.org/mozilla-central/rev/98b4083befbb https://hg.mozilla.org/mozilla-central/rev/dd81ecba7afd https://hg.mozilla.org/mozilla-central/rev/679350e2d699 https://hg.mozilla.org/mozilla-central/rev/fbb88e029c01 https://hg.mozilla.org/mozilla-central/rev/9b142eb80e40
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•