880648 - [MMS] Accented characters are not correctly sent/received in a MMS

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[isabelrios]

Attachment: MMS sent

Bug seen on Unagi v1-train
Gecko-65bbcee
Gaia-13c6246

PROCEDURE
With the device in Spanish
1.Create a new MMS, attach a file (it does not matter from where) and write for example: Más
2.Send the MMS

EXPECTED
The MMS is sent correctly, the file is ok and also the text

ACTUAL
The characters are not shown correctly. See screenshot attached.

Maybe is it realated to bug 877141?

Comment 1

[isabelrios]

Attachment: MMS received

Comment 2

[Beatriz Rodríguez [:brg]]

This issue is very important and blocking the launching dates.
The text included in a MMS should never be changed and should reach the other party in the same way it is written by the sender.
Changing the component to something more appropiate.

Comment 3

[ayman maat :maat]

(In reply to Beatriz Rodríguez [:brg] from comment #2)
> This issue is very important and blocking the launching dates.
> The text included in a MMS should never be changed and should reach the
> other party in the same way it is written by the sender.
> Changing the component to something more appropiate.

Absolutely

Comment 4

[Paul Yang [:pyang] (away)]

Reproduce by 6/10 build
Seem like SMS is also wrong on receiver

Comment 5

[Borja Salguero [:borjasalguero]]

Hi Gene! Could you help with this? Thanks!

Comment 6

[Gene Lian (I already quit Mozilla)]

Pleasure!

Comment 7

[:gerard-majax]

I can't reproduce here on gaia master as of 5ffca88

Comment 8

[:gerard-majax]

Could it be related to strict 7 bits encoding?

Comment 9

[Gene Lian (I already quit Mozilla)]

Eventually, I found out this bug doesn't relate to bug 883017. That bug addresses the issue of wrong text displaying on other parties. This bug addresses the issue of wrong text displaying on our FFOS. I can still reproduce this issue by sending a text like "Más" as mentioned at comment #0. I'm working out a solution for this issue.

Comment 10

[Gene Lian (I already quit Mozilla)]

Attachment: Part 1, content blob should be encoded by utf-8 (Gecko end)

Comment 11

[Gene Lian (I already quit Mozilla)]

Attachment: Part 2, content blob must be encoded by utf-8 (Gaia end)

Comment 12

[Gene Lian (I already quit Mozilla)]

Attachment: Part 2, content blob must be encoded by utf-8 (Gaia end)

Comment 13

[Gene Lian (I already quit Mozilla)]

Hi dietrich,

We need you help to mark leo+ for this bug which is definitely a critical issue. Thanks!

Comment 14

[Dietrich Ayala (:dietrich)]

Blocking. However, please add a test to ensure support of these types of characters in the platform layer.

Comment 15

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 763500 [details] [diff] [review]
Part 1, content blob should be encoded by utf-8 (Gecko end)

Review of attachment 763500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 16

[Steve Chung [:steveck]]

Hi Gene, I left a comment in https://github.com/mozilla-b2g/gaia/pull/10438#discussion_r4740235, thanks.

Comment 17

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 763500 [details] [diff] [review]
Part 1, content blob should be encoded by utf-8 (Gecko end)

Review of attachment 763500 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/src/ril/WspPduHelper.jsm
@@ +2308,5 @@
> +              // If the content is a "text/plain" type, we have to make sure
> +              // the encoding of the blob content should always be "utf-8".
> +              let tmpStr = this.decodeStringContent(octetArray, charset);
> +              let encoder = new TextEncoder("UTF-8");
> +              content = new Blob([encoder.encode(tmpStr)], {type : mimeType});

nit: we should also reset charset to "utf-8" here.

Comment 18

[Gene Lian (I already quit Mozilla)]

Attachment: Part 1, content blob should be encoded by utf-8 (Gecko end), V2

Addressing the comment. Thanks Vicamo and Ctai for the feedback.

Comment 19

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/projects/birch/rev/66523a98fe19

Comment 20

[Gene Lian (I already quit Mozilla)]

back out: https://hg.mozilla.org/projects/birch/rev/8863b30f36e5

reland: https://hg.mozilla.org/projects/birch/rev/37595c13b533

Comment 21

[Gene Lian (I already quit Mozilla)]

Attachment: Part 1, content blob should be encoded by utf-8 (Gecko end), V2.1

Comment 22

[Steve Chung [:steveck]]

Attachment #763505 [details] landed in gaia master: 70e1de2de1722e6ecd131d68a0a403f5e1054166

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/37595c13b533

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/636880c5d3ad

Leaving status-b2g18 set to affected for the v1-train and v1.1hd uplifts.

Comment 25

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train & 1.1hd: aea6834efc2b291971c3065eca7bdfe74a319be8

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/636880c5d3ad

Comment 27

[Beatriz Rodríguez [:brg]]

Can someone from QA verify this issue please?

Comment 28

[isabelrios]

Hi, with today's build: 
Gecko-2ff3151
Gaia-d8d189b

I cannot reproduce the problem with accented chars. Seems to be working fine now. Thanks

Comment 29

[:CSchmoeckel]

Created new MMS Suite Test Case #8905 - Send MMS message using accented characters