880679 - Edit review button redirects user to Write a review page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P4)

Description

[Iulian Timis]

Steps to reproduce:
1. Load details page for an app on production (ex. https://marketplace.firefox.com/app/twitter ).
2. Add a review.
3. Click the Edit Review button

Expected results:
User is redirected to the Edit Review page.

Actual results:
Write a review page is displayed.

Notes/Issues:
Verified on FF24 (Win 7). Issue is not reproducing on Stage or Dev.
Screencast for this issue http://screencast.com/t/4rzit0Gl
Submitted Log ID: 2cbdf

Comment 1

[Stuart Colville [:muffinresearch]]

Just tried this and it worked fine for me.

Comment 2

[Matt Basta [:basta]]

I also can't reproduce this issue.

Comment 3

[Matt Basta [:basta]]

Looking at your Ashes report (thanks for submitting!), it looks like when you hit the Edit Review page, you were diverted to the Write a Review page:

  [nav] Navigation started: /app/twitter/ratings/edit
  [views] Routing /app/twitter/ratings/edit
  ...
  [nav] Received divert event: /app/twitter/ratings/add

That specific case means that when we tried to fetch your existing review, the API returned an empty response. That means one of two things:

1. Your review didn't submit properly (the API returned a 20X incorrectly).
2. Caching in the API (or latency behind the scenes) is preventing your review from being exposed.

Try to repro again, but leave a couple minutes between when you write a review and when you edit a review. If you can't repro, that means that we're hitting the second scenario.

Some solutions:
1. Use cache rewriting (writing?) to store a copy of the review in a fake API response in the request cache.
2. Do more in the API to make sure that caches are busted and rows get replicated.
3. WONTFIX and assume that users aren't going to be writing/editing that fast.

Looping in some API guys to get their thoughts.

Comment 4

[Iulian Timis]

I'm not able to reproduce this issue anymore.

Comment 5

[Matt Basta [:basta]]

Cool, I'll add this to my list of things that need cache rewriting.

Comment 6

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/906f7bdf8167cb005a04097a812bf9de16eeb791

STR for cache rewriting:
- Add a review for something you've never reviewed
- Press "Edit Review"
- The edit review page should load instantly (no delay from contacting the server)

Probably best to test this on crappy wifi/EDGE or on an Unagi.

Comment 7

[Iulian Timis]

Verified as fixed in https://marketplace.firefox.com/ on FF24 (Win 7) and MP prod and MP-dev apps on Unagi.
Postfix screencast http://screencast.com/t/uAqfSsimLIQ
Closing bug.