880687 - Validation timeout tracebacks

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P1)

Description

[Wil Clouser [:clouserw]]

Attachment: add-on

Since our push yesterday we've been getting a lot of validation timeouts (>100).  Did something change in the AMO validator?  Are timeout reasons logged somewhere?

Attached is one of the add-ons that timed out, but I can get you any others you'd like.

Comment 3

[Kris Maglione [:kmag]]

Seems to be the bug I fixed in https://github.com/mozilla/amo-validator/pull/203

Comment 5

[Matěj Cepl]

I am not sure whether it is the same problem, but I get "unexpected server error happened while validating" immediately (i.e., it is not timeout). See the screencast on http://mcepl.fedorapeople.org/tmp/screencast-amo-upload.webm

Comment 7

[Matt Basta [:basta]]

https://github.com/mozilla/zamboni/commit/9b8b98786ffed9ec9d182e0658ec770042029f34

Leaving the bug open so that we can test that this does indeed fix the issue.

Comment 8

[Matt Basta [:basta]]

Seems to be fixed now.

Comment 9

[slemmer.balazs]

For me it still gets stuck at validation as I described in https://bugzilla.mozilla.org/show_bug.cgi?id=880681

Comment 10

[Mime Čuvalo]

Still stuck for me as well - cannot upload a new version of FireFTP. ( https://addons.mozilla.org/en-US/firefox/addon/fireftp/ )

Comment 11

[Jonathan Kamens]

It's fixed in the source tree, but the fixed version hasn't been pushed to production yet.

I think there's a schedule somewhere which documents when pushes of new versions of AMO happen, but it's impossible to find. Unfortunately, this page <https://wiki.mozilla.org/AMO> is years out-of-date. It would be nice if someone on the AMO dev team would update it, or at least put a link at the top to where more current information can be found.

Comment 12

[Mime Čuvalo]

Hm, but I see the code to commit that Matt did is only related to Jetpack addons - my addon is not a Jetpack addon so the error I'm seeing is perhaps not fixed by that?

(Besides Matt said in comment 7 he'd leave this bug open until it was fixed) I wonder if something else is going on...

Comment 13

[Matt Basta [:basta]]

You can test your add-on's submission with addons-dev.allizom.org

clouserw tentatively plans to push the fix to production on Monday.

Comment 14

[Kris Maglione [:kmag]]

(In reply to Mime Cuvalo from comment #12)
> Hm, but I see the code to commit that Matt did is only related to Jetpack
> addons - my addon is not a Jetpack addon so the error I'm seeing is perhaps
> not fixed by that?

Please file a separate bug and attach the XPI that fails.

Comment 15

[Mime Čuvalo]

Cool, thanks for your help, Matt.  Indeed it's working on allizom.org.  Strange that it's somehow my addon would be related to Jetpack validation but that's a separate question ^_^.  Thanks again!

Comment 19

[Victor Carciu]

I will mark it as verified since I was able to validate more add-ons on -dev.