Created attachment 759974 [details] screenshot Description: If the user attempts to edit an alarm, the word "edit" isn't localized. Repro Steps: 1) Updated to Unagi Build ID: 20130605070207 2) Open the Calendar App. 3) Select a day and then select the + button. 4) Create an alarm and save it. 5) Select the alarm created in the events section. Actual: The "edit" button in the upper right corner is not localized in Nederlands. Expected: "Edit" should be translated to the correct language. Environmental Variables Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09dc1ae3b1b5 Gaia: 92a6e36957145cdb2ac8867e5cdba8ecf12308fc Platform Version: 18.0 Notes: Repro frequency: 100%
I can confirm this issue (phone set to Italian) https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/index.html#L408 <span data-l10n-id="edit">Edit</span> But there's no "edit" label in the properties file https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/locales/calendar.en-US.properties
Summary: [B2G][l10n][Nederlands][Calendar]The word "Edit" isn't localized in Nederlands → [B2G][l10n][Calendar]The word "Edit" is not localizable
Widening the bug based on the same screenshot. Also "From:" and "To:" are not localizable (hard-coded). https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/index.html#L432
Summary: [B2G][l10n][Calendar]The word "Edit" is not localizable → [B2G][l10n][Calendar] Labels "Edit", "From:", "To:" are not localizable
blocking-b2g: --- → leo?
blocking-b2g: leo? → leo+
Created attachment 768845 [details] Pointer to Pull request. https://github.com/mozilla-b2g/gaia/pull/10693 Adding a pull request for localizing the "From" and "To" fields. "Edit" field is already localized. Check here https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/locales/calendar.en-US.properties#L9
(In reply to Leo from comment #4) > "Edit" field is already localized. Check here > https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/locales/ > calendar.en-US.properties#L9 It was added 4 days ago, this bug is 3 weeks old ;-) https://github.com/mozilla-b2g/gaia/commit/5de500c53d244f2bb876fef0d88e50306ba3c7e4 Apparently that string was reported in a later bug 885927 and fixed there.
so is this bug now about moving the patch from 885927 to v1-train? that would make email@example.com the assignee. assign back to nobody if this doesn't make sense. we really need to get this landed quickly if there is any chance of making the zero string change deadline of june 30.
Assignee: nobody → leo.bugzilla.gaia
(In reply to chris hofmann from comment #6) > so is this bug now about moving the patch from 885927 to v1-train? Nope. Bug 885927 fixed only part of this bug on master (the Edit button) and needs uplift to v1-train. At this point "From" and "To" are still not localizable on both master and v1-train. Updating the Summary to make it more clear.
Summary: [B2G][l10n][Calendar] Labels "Edit", "From:", "To:" are not localizable → [B2G][l10n][Calendar] Labels "From:", "To:" are not localizable
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Uplifted 24d93dce98e7c0d7ae3b5527bf8ed22189e918ee to: v1-train: cb642265ca4dd0ceaef47ad2c436eabb73f4f6b7
status-b2g18: affected → fixed
status-b2g-v1.1hd: --- → fixed
Verified on Unagi, build ID 20130701070213
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.