885927 - [b2g] [Calendar] Edit event: Button "Edit" appears in English

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: Screenshot

Leo, v1.1
Gaia   cca61224e6df8e9f7e450d77cb6a8cf91029be64
BuildID 20130621070212
Version 18.0

* Repro:
- Go into Calendar
- Create an event
- Click on that event

* Expected result: 
- Everything appears localized

* Actual result:
- the "Edit" button appears in English (see screenshot) instead of Polish

Comment 1

[Stefan Plewako [:stef]]

It needs to be localizable first.

Comment 2

[Leo]

(In reply to Stefan Plewako [:stef] from comment #1)
> It needs to be localizable first.

The edit string is localizable. But it is not added to any locale files. Please go ahead and add the new string id to each locale file. It look something like below in en-US locale file

back=Back
save=Save
hide=Hide
cancel=Cancel
confirm=Confirm
done=Done
events=Events
<Add the new string here to be localized for this language>
edit=Edit

The same needs to added for other locale files also. Please provide the localized string for all languages if you want me to do this.

Comment 3

[Stefan Plewako [:stef]]

From l10n perspective it is not localizable.

First it needs to be added to:
https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/calendar/locales/calendar.en-US.properties then it needs to be merged into
http://hg.mozilla.org/gaia-l10n/en-US/file/tip/apps/calendar/calendar.properties and then I can localize it.

Comment 4

[Leo]

Attachment: Pointer to Pull request. https://github.com/mozilla-b2g/gaia/pull/10566

A string is added for "Edit" string to locale file to enable localization.

Comment 5

[James Lal [:lightsofapollo]]

in master https://github.com/mozilla-b2g/gaia/commit/18d39f8bbf25905da1bd1df6147d815bda1052db

Comment 6

[Leo]

Now this is landed, could you help in getting the string localized?

Comment 7

[Stefan Plewako [:stef]]

No. It landed on master only and sadly we don't localize it.

It needs to be merged into v1-train and then into http://hg.mozilla.org/gaia-l10n/en-US (by Pike) - this is how it works, don't blame me.

Comment 8

[Alex Keybl [:akeybl]]

Is this a blocker for you all? This remains leo? as of right now.

Comment 9

[Axel Hecht [:Pike]]

I don't think landing this at this point has a lot of impact on what we're shipping in 1.1

Comment 10

[Jason Smith [:jsmith]]

(In reply to Axel Hecht [:Pike] from comment #9)
> I don't think landing this at this point has a lot of impact on what we're
> shipping in 1.1

I disagree. This impacts the read only view in the Calendar app, which is a 1.1 feature. If we don't take this patch, then the read only view feature will not be fully localized for 1.1.

Comment 11

[Axel Hecht [:Pike]]

Exposing the patch to localizers doesn't mean we get localized strings.

We're way past bedtime here.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Axel Hecht [:Pike] from comment #11)
> Exposing the patch to localizers doesn't mean we get localized strings.
> 
> We're way past bedtime here.

Not exposing that patch means we don't have any opportunity to get localized strings for a target 1.1 feature. That seems like a net loss IMO.

The only argument here that we be on the table here for not accepting this patch would mean either:

1) accepting we have a target 1.1 feature that won't be localized and don't take the patch
2) accepting we take a risk that a target 1.1 feature might not have all localizations and take the patch
3) alter the 1.1 read only view code to see if it use an edit
4) Disable the read only feature for 1.1

[1] I think is not the right path to go because it is a net loss - no opportunity for localizations and this will likely fail in IOT.

[2] I think is not a bad solution, but does put us at risk for missing localizations.

[3] I think if available, is the best choice to go with. It avoids doing new localizations and ensures that a target 1.1 feature is localized.

[4] Needs an argument to product to turn the feature off

needinfo on product for a call here. I'll email release drivers as well about this.

Comment 13

[Jason Smith [:jsmith]]

Alex is following up over email on this for what to do here.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 18d39f8bbf25905da1bd1df6147d815bda1052db to:
v1-train: 923ae8c993360c92b70e8bb6c3502ef5a4b2ae04

Comment 17

[Axel Hecht [:Pike]]

This is exposed to localizers, post sent to .l10n.

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 923ae8c993360c92b70e8bb6c3502ef5a4b2ae04

Comment 19

[mdaniloff]

When set to Polish language, the EDIT button is localized in Polish

Environmental Variables
Build ID: 20130729070226
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8135299f3efd
Gaia: 7aaffc8ccb6cf7ddd1e97943c108f1cb9eae5de0
Platform Version: 18.1

Comment 20

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed on today's latest Leo build. Marking as so