881154 - hdpi/xhdpi resolution assets and layout for Settings app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug represents fixes needed in Settings app in order to deliver bug 881126:

-- Have visual supply us with @1.5x and the correct @2x images.
-- On v1.1hd, modify CSS/JS so that apps will display @1.5x/@2x images correctly.
-- On master, drop the @1.5x and @2x images and make sure there is no
more to tweak besides changes made on bug 830644.

As HIDPI support never landed on v1-train, I expect the patch for both
branches on this bug will be different. The CSS/JS patch on v1.1hd will be based on the patch on master, but I won't expect it to be as simple as a |git cherry-pick|; so this is
where the engineering work lays.

The patch on top of v1-train should land on v1.1hd.

Comment 1

[Wayne Chang [:wchang]]

Setting hd+ for 1.1hd specific requirement

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/10713

Evelyn, could you help review this patch? Thanks!

Comment 3

[Evelyn Hung]

Comment on attachment 769556 [details]
link to https://github.com/mozilla-b2g/gaia/pull/10713

r=me, good job! However, some small details:
1. some toggles looks like in disable state, lighter blue. (airplane mode, geolocation, Lock Screen)
2. Bluetooth device type icons are lost.
3. Volume control bars in Sound page are slightly shorter.
Request review again when you are done. Thanks!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 769556 [details]
link to https://github.com/mozilla-b2g/gaia/pull/10713

Issue 2 is fixed. As for issue 1, we should uplift bug 880567. And for issue 3, the length is as v1-train. Please help review the change, thanks!

Comment 5

[Evelyn Hung]

Comment on attachment 769556 [details]
link to https://github.com/mozilla-b2g/gaia/pull/10713

r=me, thanks!

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, Evelyn.

1.1hd: https://github.com/mozilla-b2g/gaia/commit/a71fbaf6d88b5f2b0f701a0ced30f0a02b263df7

Comment 7

[Alex Keybl [:akeybl]]

I'm not sure if this is landed (or needs to land) to master. Can you clarify Arthur? Sorry about the re-open.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Assets have been added to master in bug 892393. And the settings app in master supports multi-resolution.

Comment 9

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0