Port INSTALL_TARGETS to comm-central

ASSIGNED
Assigned to

Status

MailNews Core
Build Config
ASSIGNED
5 years ago
3 years ago

People

(Reporter: jcranmer, Assigned: jcranmer)

Tracking

(Blocks: 1 bug)

Trunk
x86_64
Windows 7
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
The basics of this framework is INSTALL_TARGETS is a list of values (e.g., XPIDL_MODULE) such that all $1_FILES get installed to $1_DEST in $1_TARGET. This is basically added by bug 784262 and bug 773202.

It's not necessary for cc-rework, but it eliminates a lot of extra rules in Makefiles. Assuming that the install:: rules are useless these days, then this means we have no rules in the mailnews/ tree excepting mapi's MIDL generation and mailnews' xpcshell-tests kludge.
(Assignee)

Comment 1

5 years ago
Created attachment 762830 [details] [diff] [review]
Part 1: Add the INSTALL_TARGETS to rules.mk
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #762830 - Flags: review?(mbanner)
(Assignee)

Comment 2

5 years ago
Created attachment 762837 [details] [diff] [review]
Part 2: Use INSTALL_TARGETS internally to rules.mk

This isn't strictly necessary, but it brings us closer to mozilla-central's rules.mk. This patch was largely constructed by using vimdiff between the two copies, though I tried to avoid excessive changes to the comm-central copy. It also serves as a litmus test for part 1.
Attachment #762837 - Flags: review?(mbanner)
Attachment #762830 - Flags: review?(mbanner) → review+
Attachment #762837 - Flags: review?(mbanner) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/comm-central/rev/3c8b64fa8547
https://hg.mozilla.org/comm-central/rev/77cbaaba1f0d
I've just backed out part 2 of this, as my analysis on via try server was that this caused the Linux & Windows mailbloat failures.

https://hg.mozilla.org/comm-central/rev/7307fb151f1d
Also backed out on aurora:

https://hg.mozilla.org/releases/comm-aurora/rev/b3a387b1b1c3
You need to log in before you can comment on or make changes to this bug.