Open Bug 881368 Opened 6 years ago Updated 5 years ago

Port INSTALL_TARGETS to comm-central

Categories

(MailNews Core :: Build Config, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: jcranmer, Assigned: jcranmer)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The basics of this framework is INSTALL_TARGETS is a list of values (e.g., XPIDL_MODULE) such that all $1_FILES get installed to $1_DEST in $1_TARGET. This is basically added by bug 784262 and bug 773202.

It's not necessary for cc-rework, but it eliminates a lot of extra rules in Makefiles. Assuming that the install:: rules are useless these days, then this means we have no rules in the mailnews/ tree excepting mapi's MIDL generation and mailnews' xpcshell-tests kludge.
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #762830 - Flags: review?(mbanner)
This isn't strictly necessary, but it brings us closer to mozilla-central's rules.mk. This patch was largely constructed by using vimdiff between the two copies, though I tried to avoid excessive changes to the comm-central copy. It also serves as a litmus test for part 1.
Attachment #762837 - Flags: review?(mbanner)
Attachment #762830 - Flags: review?(mbanner) → review+
Attachment #762837 - Flags: review?(mbanner) → review+
I've just backed out part 2 of this, as my analysis on via try server was that this caused the Linux & Windows mailbloat failures.

https://hg.mozilla.org/comm-central/rev/7307fb151f1d
You need to log in before you can comment on or make changes to this bug.