881385 - Remove checks for text iconmodes in browser-social.js

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

There are some checks in browser-social.js that look for the navbar having mode="text", but since bug 573329 that mode doesn't exist anymore.

One of these changes landed after the patch for bug 573329 landed and another was missed in bug 573329. The mode still exists on m-c hence this not being noticed when it was merged from m-c to ux.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/ux/rev/1b4b5f70d7d3

Comment 2

[Matthew N. [:MattN]]

Jared, there is a cross-platform b-c opt perma-failure since your push:

15:05:13  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_share.js | uncaught exception - ReferenceError: aToolbarButton is not defined at chrome://browser/content/browser.js:5351
15:05:14  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_share.js | uncaught exception - ReferenceError: aToolbarButton is not defined at chrome://browser/content/browser.js:5351
15:05:42  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_share.js | Test timed out
15:05:43  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/social/browser_share.js | Found a tab after previous test timed out: https://example.com/browser/browser/base/content/test/social/opengraph/og_invalid_url.html

https://tbpl.mozilla.org/php/getParsedLog.php?id=23983043&tree=UX

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Pushed https://hg.mozilla.org/projects/ux/rev/8a9bf2595921 to fix the test orange.

Comment 4

[:Gijs (out for now; he/him)]

https://hg.mozilla.org/mozilla-central/rev/1b4b5f70d7d3
https://hg.mozilla.org/mozilla-central/rev/8a9bf2595921