881632 - [socorro-crashstats] Unable to display Graph Data from Top Crashers

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Scoobidiver (away)]

When clicking the graph data glyph for a signature, the loading bar stays indefinitely.

See https://crash-stats-django.allizom.org/topcrasher/products/Firefox/versions/24.0a1

Comment 1

[Robert Helmer [:rhelmer]]

https://crash-stats-django.allizom.org/topcrasher/plot_signature/Firefox/24.0a1/2013-06-03/2013-06-10/js%253A%253Atypes%253A%253AIdToTypeId%2528int%2529

https://errormill.mozilla.org/webtools/socorro-crashstats-stage/group/16110/

Types: 	

BadStatusCodeError

Value: 	

500: on: http://socorro-mware-stage-zlb.webapp.phx1.mozilla.com/bpapi/topcrash/sig/trend/history/p/Firefox/v/24.0a1/sig/js%253A%253Atypes%253A%253AIdToTypeId%2528int%2529/end/2013-06-10T00%3A00%3A00/duration/168.0/steps/60/

Location: 	crashstats/crashstats/models.py in fetch , line 139

Comment 2

[Robert Helmer [:rhelmer]]

Adrian, can you take a look at this please? Should we just int(duration) on the django side?

Jun 11 01:03:26 Socorro Web Services (pid 21238): 2013-06-11 01:03:26,482 ERROR - Dummy-3 - File "/data/socorro/application/socorro/lib/datetimeutil.py", line 21, in strHoursToTimeDelta#012    return datetime.timedelta(hours=int(hoursAsString))
Jun 11 01:03:26 Socorro Web Services (pid 21238): 2013-06-11 01:03:26,482 ERROR - Dummy-3 - ValueError: invalid literal for int() with base 10: '168.0'

Comment 3

[Robert Helmer [:rhelmer]]

Hmm this is already ('duration', int) in the SignatureTrend model, but I see in the view how it'd be cast as a float.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro-crashstats/pull/371

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/eca4670e57e8b9295ea630e23b8cfcea7bb1d4c0
Fixes bug 881632 - Forced duration to be an int (was a float).

https://github.com/mozilla/socorro-crashstats/commit/37168b9b8bd0b2ad74d57e3cc09c685e168423da
Merge pull request #371 from AdrianGaudebert/881632-duration-as-int

Fixes bug 881632 - Forced duration to be an int (was a float).

Comment 6

[Scoobidiver (away)]

It's not fixed.

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

I'm re-fixing this bug, the original problem is solved. There is an other one that will be fixed in bug 887300.