Closed
Bug 881777
Opened 10 years ago
Closed 10 years ago
Search suggestion rows in new about:home are too tall
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: lucasr, Unassigned)
References
Details
(Whiteboard: fixed-fig)
Attachments
(4 files)
80.99 KB,
image/png
|
Details | |
90.15 KB,
image/png
|
Details | |
3.26 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
1.58 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
Just wondering if that's intended or just something that needs fixing. Sriram?
Comment 1•10 years ago
|
||
They are having a height of 64dp, as per the spec. http://hg.mozilla.org/projects/fig/file/72e003d38d00/mobile/android/base/resources/values/dimens.xml#l40
Reporter | ||
Comment 2•10 years ago
|
||
Ok. Maybe the search suggestions should have different height then? Ian, what's the expected height for search suggestion rows?
Flags: needinfo?(ibarlow)
Reporter | ||
Updated•10 years ago
|
Summary: Rows in new about:home are too tall → Search suggestion rows in new about:home are too tall
Comment 3•10 years ago
|
||
Can I see a screenshot of what it looks like in its current state?
Flags: needinfo?(ibarlow)
Reporter | ||
Comment 4•10 years ago
|
||
Reporter | ||
Comment 5•10 years ago
|
||
Reporter | ||
Comment 6•10 years ago
|
||
Ian, maybe it's a matter of vertically centering the suggestions?
Comment 7•10 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #6) > Ian, maybe it's a matter of vertically centering the suggestions? Seems like a good first step ;) You could also start the single line suggestions height to be the same as the URL/Action bar: http://cl.ly/image/0r1W362t3c0I
Reporter | ||
Comment 8•10 years ago
|
||
Attachment #761504 -
Flags: review?(sriram)
Reporter | ||
Comment 9•10 years ago
|
||
Attachment #761506 -
Flags: review?(sriram)
Updated•10 years ago
|
Attachment #761504 -
Flags: review?(sriram) → review+
Updated•10 years ago
|
Attachment #761506 -
Flags: review?(sriram) → review+
Comment 10•10 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #9) > Created attachment 761506 [details] [diff] [review] > (2/2) Adjust favicon margins in SearchEngineRow Looks like bug 880525. Think this patch can land on m-c?
Reporter | ||
Comment 11•10 years ago
|
||
(In reply to Brian Nicholson (:bnicholson) from comment #10) > (In reply to Lucas Rocha (:lucasr) from comment #9) > > Created attachment 761506 [details] [diff] [review] > > (2/2) Adjust favicon margins in SearchEngineRow > > Looks like bug 880525. Think this patch can land on m-c? The code has changed quite a bit in fig. So, I'd have to write a slightly different patch for bug 880525.
Reporter | ||
Comment 12•10 years ago
|
||
Pushed: http://hg.mozilla.org/projects/fig/rev/86cf65db4547 http://hg.mozilla.org/projects/fig/rev/d5ab1e6fced4
Whiteboard: fixed-fig
Comment 13•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86cf65db4547 https://hg.mozilla.org/mozilla-central/rev/d5ab1e6fced4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•