Search suggestion rows in new about:home are too tall

RESOLVED FIXED in Firefox 26

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: lucasr, Unassigned)

Tracking

unspecified
Firefox 26
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-fig)

Attachments

(4 attachments)

Reporter

Description

6 years ago
Just wondering if that's intended or just something that needs fixing. Sriram?
Reporter

Comment 2

6 years ago
Ok. Maybe the search suggestions should have different height then? Ian, what's the expected height for search suggestion rows?
Flags: needinfo?(ibarlow)
Reporter

Updated

6 years ago
Summary: Rows in new about:home are too tall → Search suggestion rows in new about:home are too tall
Can I see a screenshot of what it looks like in its current state?
Flags: needinfo?(ibarlow)
Reporter

Comment 4

6 years ago
Posted image Screenshot 1
Reporter

Comment 5

6 years ago
Posted image Screenshot 2
Reporter

Comment 6

6 years ago
Ian, maybe it's a matter of vertically centering the suggestions?
(In reply to Lucas Rocha (:lucasr) from comment #6)
> Ian, maybe it's a matter of vertically centering the suggestions?

Seems like a good first step ;)

You could also start the single line suggestions height to be the same as the URL/Action bar: http://cl.ly/image/0r1W362t3c0I
Attachment #761504 - Flags: review?(sriram) → review+
Attachment #761506 - Flags: review?(sriram) → review+
(In reply to Lucas Rocha (:lucasr) from comment #9)
> Created attachment 761506 [details] [diff] [review]
> (2/2) Adjust favicon margins in SearchEngineRow

Looks like bug 880525. Think this patch can land on m-c?
Reporter

Comment 11

6 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #10)
> (In reply to Lucas Rocha (:lucasr) from comment #9)
> > Created attachment 761506 [details] [diff] [review]
> > (2/2) Adjust favicon margins in SearchEngineRow
> 
> Looks like bug 880525. Think this patch can land on m-c?

The code has changed quite a bit in fig. So, I'd have to write a slightly different patch for bug 880525.
https://hg.mozilla.org/mozilla-central/rev/86cf65db4547
https://hg.mozilla.org/mozilla-central/rev/d5ab1e6fced4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.