Closed Bug 881777 Opened 7 years ago Closed 7 years ago

Search suggestion rows in new about:home are too tall

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: lucasr, Unassigned)

References

Details

(Whiteboard: fixed-fig)

Attachments

(4 files)

Just wondering if that's intended or just something that needs fixing. Sriram?
Ok. Maybe the search suggestions should have different height then? Ian, what's the expected height for search suggestion rows?
Flags: needinfo?(ibarlow)
Summary: Rows in new about:home are too tall → Search suggestion rows in new about:home are too tall
Can I see a screenshot of what it looks like in its current state?
Flags: needinfo?(ibarlow)
Attached image Screenshot 1
Attached image Screenshot 2
Ian, maybe it's a matter of vertically centering the suggestions?
(In reply to Lucas Rocha (:lucasr) from comment #6)
> Ian, maybe it's a matter of vertically centering the suggestions?

Seems like a good first step ;)

You could also start the single line suggestions height to be the same as the URL/Action bar: http://cl.ly/image/0r1W362t3c0I
Attachment #761504 - Flags: review?(sriram) → review+
Attachment #761506 - Flags: review?(sriram) → review+
(In reply to Lucas Rocha (:lucasr) from comment #9)
> Created attachment 761506 [details] [diff] [review]
> (2/2) Adjust favicon margins in SearchEngineRow

Looks like bug 880525. Think this patch can land on m-c?
(In reply to Brian Nicholson (:bnicholson) from comment #10)
> (In reply to Lucas Rocha (:lucasr) from comment #9)
> > Created attachment 761506 [details] [diff] [review]
> > (2/2) Adjust favicon margins in SearchEngineRow
> 
> Looks like bug 880525. Think this patch can land on m-c?

The code has changed quite a bit in fig. So, I'd have to write a slightly different patch for bug 880525.
https://hg.mozilla.org/mozilla-central/rev/86cf65db4547
https://hg.mozilla.org/mozilla-central/rev/d5ab1e6fced4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.