880525 - Search suggestions are misaligned on tablets

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: screenshot

See screenshot. The icons for the search engines are centered, but the suggestions are aligned to the top of the row. Using Galaxy Note 10.1.

Comment 1

[Ian Barlow (:ibarlow)]

That search suggest opt-in bar should run all the way from left to right edges, too :(

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I wonder if this is related to bug 880513.

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to Ian Barlow (:ibarlow) from comment #1)
> That search suggest opt-in bar should run all the way from left to right
> edges, too :(

Yeah, filed that separately as bug bug 880513.

Comment 4

[Sriram Ramasubramanian [:sriram]]

This was fixed by lucasr recently. May be on fig.

Comment 5

[Sriram Ramasubramanian [:sriram]]

May be: bug 881777

Comment 6

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch sets the padding to the entire tabs section and not just the view-pager.
This way, the sides are blue and the list is contained in-between.

I need to check with Ian on how the tab-widget should be. I would post a patch if we wants to change something there.

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 766930 [details] [diff] [review]
Patch

Wrong patch/bug.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - If this was fixed on Fig, we need to move the fix to m-c. But just the fix for the suggestions, not anything else. This is affecting Fx24 which is headed to Beta soon.

Comment 9

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

That was one line change and I was lazy :(

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 787785 [details] [diff] [review]
Patch

Remember to try to uplift to Fx25 and Fx24

Comment 11

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/fx-team/rev/676b8b1ea011

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/676b8b1ea011