Closed Bug 882504 Opened 10 years ago Closed 10 years ago

Defect - Change sliding directions of toggle switch in Settings flyout

Categories

(Firefox for Metro Graveyard :: Theme, defect, P2)

Product:
Firefox for Metro Graveyard
Component:
Theme
Platform:
All
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 25

People

(Reporter: ywang, Assigned: mbrubeck)

References

Details

(Keywords: ux-consistency, Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=3)

Attachments

(1 file)

patch
1.59 KB, patch
jwilde
: review+
Details | Diff | Splinter Review 
Right now, on the settings flyout, the slider stays on the left when the state is "ON", on the right when the state is "OFF".

This sliding direction is the opposite with most ON/OFF switches. Usually "ON"->"OFF" is better visualized by "left to right". iOS used sliding right to unlock...
 
See the mockup in this story bug for details: https://bugzilla.mozilla.org/show_bug.cgi?id=831958
Blocks: 831958, metrov1defect&change
Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=0
Component: Flyouts → Theme
I think these should be rtl aware as well, flipping directions accordingly.
Priority: -- → P2
Assignee: nobody → mbrubeck
Hey Matt, reminder to provide a point estimate no later than this Sunday.
Flags: needinfo?(mbrubeck)
Estimated effort: p=3
Flags: needinfo?(mbrubeck)
Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=0 → feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=3
Blocks: metrov1it11
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
QA Contact: jbecerra
Attached patch patch — — Splinter Review 
Well, that was easier than I thought it would be.  And it looks like this binding already adapts correctly in RTL locales (with or without this patch).
Attachment #776016 - Flags: review?(jwilde)
Attachment #776016 - Flags: review?(jwilde) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9593e9c0415a
Flags: in-testsuite-
Keywords: ux-consistency
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/9593e9c0415a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
The dirrections are now flipped, the slider stays on the left when the state is "OFF", and on the right when the state is "ON".

Verified on latest nightly (build ID: 20130730030204)
Status: RESOLVED → VERIFIED
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12.
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.