Closed Bug 882504 Opened 6 years ago Closed 6 years ago
Defect - Change sliding directions of toggle switch in Settings flyout
Right now, on the settings flyout, the slider stays on the left when the state is "ON", on the right when the state is "OFF". This sliding direction is the opposite with most ON/OFF switches. Usually "ON"->"OFF" is better visualized by "left to right". iOS used sliding right to unlock... See the mockup in this story bug for details: https://bugzilla.mozilla.org/show_bug.cgi?id=831958
I think these should be rtl aware as well, flipping directions accordingly.
Hey Matt, reminder to provide a point estimate no later than this Sunday.
Estimated effort: p=3
Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=0 → feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=3
Well, that was easier than I thought it would be. And it looks like this binding already adapts correctly in RTL locales (with or without this patch).
Attachment #776016 - Flags: review?(jwilde)
Attachment #776016 - Flags: review?(jwilde) → review+
Hardware: x86 → All
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
The dirrections are now flipped, the slider stays on the left when the state is "OFF", and on the right when the state is "ON". Verified on latest nightly (build ID: 20130730030204)
Status: RESOLVED → VERIFIED
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 Build ID: 20130815030203 Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc WFM Tested on windows 8 using latest nightly for iteration-12.
You need to log in before you can comment on or make changes to this bug.