882504 - Defect - Change sliding directions of toggle switch in Settings flyout

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Theme, defect, P2)

Description

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Right now, on the settings flyout, the slider stays on the left when the state is "ON", on the right when the state is "OFF".

This sliding direction is the opposite with most ON/OFF switches. Usually "ON"->"OFF" is better visualized by "left to right". iOS used sliding right to unlock...
 
See the mockup in this story bug for details: https://bugzilla.mozilla.org/show_bug.cgi?id=831958

Comment 1

[Jim Mathies [:jimm]]

I think these should be rtl aware as well, flipping directions accordingly.

Comment 2

[Marco Mucci [:MarcoM]]

Hey Matt, reminder to provide a point estimate no later than this Sunday.

Comment 3

[Matt Brubeck (:mbrubeck)]

Estimated effort: p=3

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Well, that was easier than I thought it would be.  And it looks like this binding already adapts correctly in RTL locales (with or without this patch).

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9593e9c0415a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9593e9c0415a

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

The dirrections are now flipped, the slider stays on the left when the state is "OFF", and on the right when the state is "ON".

Verified on latest nightly (build ID: 20130730030204)

Comment 8

[Samvedana (:Samvedana)]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc

WFM
Tested on windows 8 using latest nightly for iteration-12.