882593 - [MMS] Multi-recipient. Contact's picture is not shown when the group participant info is displayed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[isabelrios]

Unagi device:
Gecko-68ad212
Gaia-ea18de8

PROCEDURE
There should be at least one contact with picture in the addressbook

1. Open Messaging app and create a MMS
2. Select the contact with picture and type any phone number not associated with a contact.
3. Send the MMS
4. Once the MMS is sent, tap on the header to see the group info details
5. Tap on the contact name

EXPECTED
According to latest doc: HTML5_SMS-MMSUserStorySpecifications_20130503_V8.0
On pag#14 -> Step 4., on the group info screen there should appear the contact's picture.
Aslo, on pag#16 -> Step 5., on the contact details view, the picture should be also shown.

ACTUAL
Contact info is shown ok but the picture is missing in both steps.

Feedback from UX (ccing Ayman), there are two main reason to have this bug fixed:
-An image is as important as the contact name for identifying a contact
-Images are associated to cantacts and should be used wherever possible

Comment 1

[Rick Waldron [:rwaldron]]

This should be trivial for anyone with a good understanding of the CSS. Unfortunately, I lack that understanding, but I'll gladly make myself available for review of the logic aspects :)

Comment 2

[Fernando Campo (:fcampo)]

Attachment: Link to PR

Comment 3

[Rick Waldron [:rwaldron]]

PR notes https://github.com/mozilla-b2g/gaia/pull/10442/files#L1L1459

Comment 4

[Rick Waldron [:rwaldron]]

(just making this searchable with the rest of the tickets that include "multi-recipient")

Comment 5

[Fernando Campo (:fcampo)]

I added some tests, so probably ready for a full review

Comment 6

[Wayne Chang [:wchang]]

Rick, are you able to review this so we can get this closed too?

thanks.

Comment 7

[Rick Waldron [:rwaldron]]

Wayne, the patch needs to be rebased before I can review/test

Comment 8

[Fernando Campo (:fcampo)]

Yup, sorry for the delay, I was on holidays last days.

I just rebased the code, so I think it can be reviewed any time.

On a side note, as I just came back from some days off and I'm a little lost after the latest changes...how are we applying the rules on reviewing/merging? is still needed to have the r+ from a peer? do we have an updated list with all the peers?

Comment 9

[Borja Salguero [:borjasalguero]]

Comment on attachment 763543 [details] [review]
Link to PR

Reviewed. Waiting some changes commented in the PR. Let me know when you are ready and I'll take a look again!

Comment 10

[Borja Salguero [:borjasalguero]]

Comment on attachment 763543 [details] [review]
Link to PR

Thanks for the patch! R+ :)

Comment 11

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/af0e322d36d2a863afd05d0ead5a9e8fd8254f7a
https://github.com/fcampo/gaia/commit/d1b6f57aba3e3e5027194d588ebaef0b8720c569
R+. Merged1

Comment 12

[Borja Salguero [:borjasalguero]]

John, could you take a look about the uplift? Thanks!

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted af0e322d36d2a863afd05d0ead5a9e8fd8254f7a to:
v1-train: ef9f5c5f86249048597e91bcbc779b4a1f7a3594

Comment 14

[isabelrios]

Hi,
Checking this bug with unagi v1-train 07/21 build:

Gecko-1fc50aa
Gaia-c4bdd32
Ref. ril.

There were two situations failing: 
-On pag#14 -> Step 4., on the group info screen there should appear the contact's picture.
-Also, on pag#16 -> Step 5., on the contact details view, the picture should be also shown.

Only the first one appears fixed.
-On pag#14 -> Step 4., on the group info screen there should appear the contact's picture. 

Ni? Fernando Campo and Ayman to calrify if that was agreed that way to verify this bug or not. 
Thanks

Comment 15

[Fernando Campo (:fcampo)]

Yup, that wasn't fixed, my mistake :(

If you can open a followup, I'll work on it right away

Thanks

Comment 16

[isabelrios]

Follow up already created: bug896368

Comment 17

[isabelrios]

Verified with unagi device v1-train 07/22:
Gecko-1fc50aa
Gaia-06d56e0

Firs issue is already fixed: 
On pag#14 -> Step 4., on the group info screen there should appear the contact's picture.

And for this one: On pag#16 -> Step 5., on the contact details view, the picture should be also shown, the follow up bug896368 has been created

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: ef9f5c5f86249048597e91bcbc779b4a1f7a3594