Closed Bug 882593 Opened 7 years ago Closed 7 years ago

[MMS] Multi-recipient. Contact's picture is not shown when the group participant info is displayed

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

x86_64
Windows 7
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

VERIFIED FIXED
1.1 QE4 (15jul)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: isabelrios, Assigned: fcampo)

References

Details

(Whiteboard: MMS_TEF, [u=commsapps-user c=messaging p=1])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review
Unagi device:
Gecko-68ad212
Gaia-ea18de8

PROCEDURE
There should be at least one contact with picture in the addressbook

1. Open Messaging app and create a MMS
2. Select the contact with picture and type any phone number not associated with a contact.
3. Send the MMS
4. Once the MMS is sent, tap on the header to see the group info details
5. Tap on the contact name

EXPECTED
According to latest doc: HTML5_SMS-MMSUserStorySpecifications_20130503_V8.0
On pag#14 -> Step 4., on the group info screen there should appear the contact's picture.
Aslo, on pag#16 -> Step 5., on the contact details view, the picture should be also shown.

ACTUAL
Contact info is shown ok but the picture is missing in both steps.

Feedback from UX (ccing Ayman), there are two main reason to have this bug fixed:
-An image is as important as the contact name for identifying a contact
-Images are associated to cantacts and should be used wherever possible
Summary: [MMS] Multirecipient. Contact's picture is not shown when the group participan info is displayed → [MMS] Multirecipient. Contact's picture is not shown when the group participant info is displayed
Assignee: nobody → fernando.campo
This should be trivial for anyone with a good understanding of the CSS. Unfortunately, I lack that understanding, but I'll gladly make myself available for review of the logic aspects :)
blocking-b2g: leo? → leo+
Attached file Link to PR
Attachment #763543 - Flags: review?(waldron.rick)
Blocks: 881076
(just making this searchable with the rest of the tickets that include "multi-recipient")
Summary: [MMS] Multirecipient. Contact's picture is not shown when the group participant info is displayed → [MMS] Multi-recipient. Contact's picture is not shown when the group participant info is displayed
I added some tests, so probably ready for a full review
Whiteboard: MMS_TEF → MMS_TEF, [u=commsapps-user c=messaging p=0]
Rick, are you able to review this so we can get this closed too?

thanks.
Flags: needinfo?(waldron.rick)
Wayne, the patch needs to be rebased before I can review/test
Flags: needinfo?(waldron.rick)
Attachment #763543 - Flags: review?(fbsc)
Whiteboard: MMS_TEF, [u=commsapps-user c=messaging p=0] → MMS_TEF, [u=commsapps-user c=messaging p=1]
Yup, sorry for the delay, I was on holidays last days.

I just rebased the code, so I think it can be reviewed any time.

On a side note, as I just came back from some days off and I'm a little lost after the latest changes...how are we applying the rules on reviewing/merging? is still needed to have the r+ from a peer? do we have an updated list with all the peers?
Priority: -- → P1
Target Milestone: --- → 1.1 QE5
Target Milestone: 1.1 QE5 → 1.1 QE4 (15jul)
Comment on attachment 763543 [details] [review]
Link to PR

Reviewed. Waiting some changes commented in the PR. Let me know when you are ready and I'll take a look again!
Attachment #763543 - Flags: review?(waldron.rick)
Attachment #763543 - Flags: review?(fbsc)
Comment on attachment 763543 [details] [review]
Link to PR

Thanks for the patch! R+ :)
Attachment #763543 - Flags: review+
John, could you take a look about the uplift? Thanks!
Flags: needinfo?(jhford)
Uplifted af0e322d36d2a863afd05d0ead5a9e8fd8254f7a to:
v1-train: ef9f5c5f86249048597e91bcbc779b4a1f7a3594
Hi,
Checking this bug with unagi v1-train 07/21 build:

Gecko-1fc50aa
Gaia-c4bdd32
Ref. ril.

There were two situations failing: 
-On pag#14 -> Step 4., on the group info screen there should appear the contact's picture.
-Also, on pag#16 -> Step 5., on the contact details view, the picture should be also shown.

Only the first one appears fixed.
-On pag#14 -> Step 4., on the group info screen there should appear the contact's picture. 

Ni? Fernando Campo and Ayman to calrify if that was agreed that way to verify this bug or not. 
Thanks
Flags: needinfo?(fernando.campo)
Flags: needinfo?(aymanmaat)
Yup, that wasn't fixed, my mistake :(

If you can open a followup, I'll work on it right away

Thanks
Flags: needinfo?(fernando.campo)
Flags: needinfo?(aymanmaat)
Follow up already created: bug896368
Flags: needinfo?(jhford)
Verified with unagi device v1-train 07/22:
Gecko-1fc50aa
Gaia-06d56e0

Firs issue is already fixed: 
On pag#14 -> Step 4., on the group info screen there should appear the contact's picture.

And for this one: On pag#16 -> Step 5., on the contact details view, the picture should be also shown, the follow up bug896368 has been created
Status: RESOLVED → VERIFIED
v1.1.0hd: ef9f5c5f86249048597e91bcbc779b4a1f7a3594
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.