get rid of BOUNDARY_ATTRIBUTE_RANGE

RESOLVED FIXED in mozilla25

Status

()

Core
Disability Access APIs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug)

unspecified
mozilla25
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
It was introduced in beginning of times in bug 151048 as part of ATK work. It got its first implementation in bug 312093. It got a current face in bug 445513. It doesn't have equivalent in IAccessible2 (http://accessibility.linuxfoundation.org/a11yspecs/ia2/api/AccessibleText.idl) or ATK (https://developer.gnome.org/atk/stable/AtkText.html#AtkTextBoundary). However ATK-based screen readers can obtain it if proper value instead the AtkTextBoundary is given.

Implementation is a combination of GetTextAttributes and GetText, it doesn't seem very useful. On the another hand, all three methods getTextAt/Before/After shares same implementation what doesn't sound right.

There's no real clarification why this constant was needed (except a short talk in bug 340809 comment #25) but still it doesn't seem I had a good understanding those times what this constants is for.

So I suggest to remove it.
(Assignee)

Updated

4 years ago
Blocks: 613857
(Assignee)

Comment 1

4 years ago
Created attachment 762021 [details] [diff] [review]
patch
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #762021 - Flags: review?(trev.saunders)
Comment on attachment 762021 [details] [diff] [review]
patch

>-    case BOUNDARY_ATTRIBUTE_RANGE:
>-    {
>-      nsresult rv = GetTextAttributes(false, offset,
>-                                      aStartOffset, aEndOffset, nullptr);

I fell like I saw some complexity in text attributes getting code that may have just been for this, it might be worth a look to see if you can rip more out :)

r=me if you nuke the constant in nsIAccessibleText.idl too
Attachment #762021 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #2)

> I fell like I saw some complexity in text attributes getting code that may
> have just been for this, it might be worth a look to see if you can rip more
> out :)

no, no, the complexity is because of API


> r=me if you nuke the constant in nsIAccessibleText.idl too

yep, I forgot about it.
https://hg.mozilla.org/mozilla-central/rev/e42886a7cff4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.