Closed
Bug 882848
Opened 13 years ago
Closed 13 years ago
Use MOCHITEST_BROWSER_FILES more
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
23.80 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #762199 -
Flags: review?(gps)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 762199 [details] [diff] [review]
Patch v1
Review of attachment 762199 [details] [diff] [review]:
-----------------------------------------------------------------
THANK YOU. THANK YOU. THANK YOU.
These rules have pained me for so long. Good riddance.
::: browser/devtools/responsivedesign/test/Makefile.in
@@ +1,3 @@
> +# This Source Code Form is subject to the terms of the Mozilla Public
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
Cargo cult!
::: toolkit/mozapps/plugins/tests/Makefile.in
@@ -34,5 @@
> $(PROGRAMS): $(TESTROOT)/% : %$(BIN_SUFFIX)
> cp $< $@
>
> -libs::
> - $(INSTALL) $(foreach f,$(_BROWSER_FILES),"$(srcdir)/$f") $(TESTROOT)
Wow.
Attachment #762199 -
Flags: review?(gps) → review+
|
Assignee | |
Comment 3•13 years ago
|
||
I hit a failure on try that I blamed on this patch at first, but turned out to be something else. I expect to land it tomorrow morning.
Flags: needinfo?(Ms2ger)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•