"Found 5 matching lines in 2 files"
With this patch can now run things like: TEST_PATH=suite/common/ make -C $OBJ_DIR mochitest-chrome TEST_PATH=suite/browser/test/browser/ make -C $OBJ_DIR mochitest-browser-chrome SM starts, not all tests pass but fixing those is probably outside the scope of this bug.
Attachment #8600943 - Flags: review?(philip.chee)
Comment on attachment 8600943 [details] [diff] [review] Port mochitest changes Your patch looks remarkably like http://hg.mozilla.org/comm-central/rev/de2df507d8e7 which unfortunately was backed out of comm-central > -TEST_DIRS += ['test'] > +BROWSER_CHROME_MANIFESTS += [ > + 'test/browser/browser.ini', > +] .... This looks more compact. http://hg.mozilla.org/comm-central/rev/de2df507d8e7#l5.9 > [browser_bug462289.js] > skip-if = toolkit == "cocoa"[browser_bug519216.js] > [browser_bug561636.js] Em, I think there should be an extra newline somewhere there. > [DEFAULT] What does [DEFAULT] do? > support-files = > alltabslistener.html In some places you interleave tests with support files and in others you group all the support files together. Is there any reason for this? I notice that in Brian O'Keefe's version common support files get their own grouping plus each test has interleaved support files if any. Other than that everything works modulo failing tests. Non-review notes: The locations of the tests seem to have changed slightly e.g. TEST_PATH=suite/browser/test/browser_bug561636.js mozmake -C ../objdir-sm/ mochitest-browser-chrome => TEST_PATH=suite/browser/test/browser/browser_bug561636.js mozmake -C ../objdir-sm/ mochitest-browser-chrome TEST_PATH=suite/browser/test/test_contextmenu.html mozmake -C ../objdir-sm/ mochitest-plain => TEST_PATH=suite/browser/test/mochitest/test_contextmenu.html mozmake -C ../objdir-sm/ mochitest-plain TEST_PATH=suite/browser/test/test_maxSniffing.html mozmake -C ../objdir-sm/ mochitest-chrome => TEST_PATH=suite/browser/test/chrome/test_maxSniffing.html mozmake -C ../objdir-sm/ mochitest-chrome
Attachment #8600943 - Flags: review?(philip.chee) → review+
Carrying forward r=
Attachment #8602363 - Flags: review+
Comment on attachment 8602363 [details] [diff] [review] Port mochitest changes v2 [Checked in: Comment 6] https://hg.mozilla.org/comm-central/rev/c6b02f52cc88
Attachment #8602363 - Attachment description: Port mochitest changes v2 → Port mochitest changes v2 [Checked in: Comment 6]
You need to log in before you can comment on or make changes to this bug.