If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[B2G] [CDMA] Update nsIDOMMozMobileCellInfo to also report base station id, base station latitude, base station longitude, system id, network id

RESOLVED FIXED in mozilla25

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Anshul, Assigned: edgar)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla25
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(5 attachments, 8 obsolete attachments)

2.56 KB, patch
edgar
: review+
Details | Diff | Splinter Review
8.75 KB, patch
edgar
: review+
Details | Diff | Splinter Review
1.56 KB, patch
edgar
: review+
Details | Diff | Splinter Review
1.37 KB, patch
edgar
: review+
Details | Diff | Splinter Review
3.59 KB, patch
edgar
: review+
Details | Diff | Splinter Review
(Reporter)

Description

4 years ago
This information would be needed for any clients like GPS.

Updated

4 years ago
Assignee: nobody → echen
Component: General → DOM: Device Interfaces
OS: All → Gonk (Firefox OS)
Product: Boot2Gecko → Core
Created attachment 771190 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v1
Attachment #771190 - Attachment description: Part 1: Expose CDMA registration information to mozMobileCellInfo → Part 1: Expose CDMA registration information to mozMobileCellInfo, v1
Created attachment 771191 [details] [diff] [review]
Part 2: RIL implementation for exposing CDMA registration information, v1
Created attachment 771192 [details] [diff] [review]
Part 3: Fix xpcshell tests, v1

Updated

4 years ago
Blocks: 874446

Updated

4 years ago
Blocks: 890822
Created attachment 777666 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v2
Attachment #771190 - Attachment is obsolete: true
Comment on attachment 777666 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v2

I expose cdma registration information to mozMobileCellInfo and also define the value for each field when the information is unavailable. Could you give some feedback, hsinyi
Attachment #777666 - Flags: feedback?
Attachment #777666 - Flags: feedback? → feedback?(htsai)
Comment on attachment 777666 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v2

Review of attachment 777666 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #777666 - Flags: feedback?(htsai) → feedback+
Created attachment 778296 [details] [diff] [review]
Part 2: RIL implementation for exposing CDMA registration information, v2
Attachment #771191 - Attachment is obsolete: true
Created attachment 778298 [details] [diff] [review]
Part 3: GPS changes for MobileCellInfo, v1
Created attachment 778300 [details] [diff] [review]
Part 4: Fix xpcshell tests, v1
Attachment #771192 - Attachment is obsolete: true
Created attachment 778301 [details] [diff] [review]
Part 5: Marionette tests for cdma registration information, v1
Attachment #777666 - Flags: review?(htsai)
Attachment #778296 - Flags: review?(htsai)
Attachment #778300 - Flags: review?(htsai)
Attachment #778301 - Flags: review?(htsai)
Comment on attachment 777666 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v2

Hi Mounir:

This bug is for exposing cdma registration information which would be needed for GPS clients to MobileCellInfo. Please help to review the interface changes.

Thanks in advance.
Attachment #777666 - Flags: superreview?(mounir)
Comment on attachment 778298 [details] [diff] [review]
Part 3: GPS changes for MobileCellInfo, v1

Kan-Ru, we change the the type of gsmLocationAreaCode and gsmCellId in this bug, and it is needed to change some codes in GPS as well, could you help to review this? Thanks in advance.
Attachment #778298 - Flags: review?(kchen)
Comment on attachment 778298 [details] [diff] [review]
Part 3: GPS changes for MobileCellInfo, v1

Review of attachment 778298 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with following addressed.

::: dom/system/gonk/GonkGPSGeolocationProvider.cpp
@@ +484,5 @@
> +        int32_t lac;
> +        int64_t cid;
> +
> +        cell->GetGsmLocationAreaCode(&lac);
> +        if (lac >= 0x0 && lac <= 0xffff) {

Comment the magic number 0xffff. Or use a constant like MAX_GSM_LAC to hold that.

@@ +489,5 @@
> +          location.u.cellID.lac = lac;
> +        }
> +
> +        cell->GetGsmCellId(&cid);
> +        if (cid >= 0x0 && cid <= 0xffffffff) {

Ditto.
Attachment #778298 - Flags: review?(kchen) → review+
Comment on attachment 778296 [details] [diff] [review]
Part 2: RIL implementation for exposing CDMA registration information, v2

Review of attachment 778296 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! Thank you :)
Attachment #778296 - Flags: review?(htsai) → review+
Comment on attachment 778300 [details] [diff] [review]
Part 4: Fix xpcshell tests, v1

Review of attachment 778300 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!!!
Attachment #778300 - Flags: review?(htsai) → review+
Comment on attachment 778301 [details] [diff] [review]
Part 5: Marionette tests for cdma registration information, v1

Review of attachment 778301 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

Would you please file another follow-up bug for cdma marionette tests? Thank you.
Attachment #778301 - Flags: review?(htsai) → review+
Comment on attachment 777666 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v2

Review of attachment 777666 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #777666 - Flags: review?(htsai) → review+
Blocks: 896396
Comment on attachment 777666 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v2

Review of attachment 777666 [details] [diff] [review]:
-----------------------------------------------------------------

Hsin-Yi's review should be enough here.
Attachment #777666 - Flags: superreview?(mounir)
(In reply to Mounir Lamouri (:mounir) from comment #18)
> Comment on attachment 777666 [details] [diff] [review]
> Part 1: Expose CDMA registration information to mozMobileCellInfo, v2
> 
> Review of attachment 777666 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Hsin-Yi's review should be enough here.

Got it.
Thanks, Mounir!
Created attachment 780172 [details] [diff] [review]
Part 1: Expose CDMA registration information to mozMobileCellInfo, v2, r=hsinyi

Add r=hsinyi after r+.
Attachment #777666 - Attachment is obsolete: true
Attachment #780172 - Flags: review+
Created attachment 780173 [details] [diff] [review]
Part 2: RIL implementation for exposing CDMA registration information, v3, r=hsinyi

1). Rebase.
2). Add r=hsinyi after r+.
Attachment #778296 - Attachment is obsolete: true
Attachment #780173 - Flags: review+
Created attachment 780174 [details] [diff] [review]
Part 3: GPS changes for MobileCellInfo, v2, r=kchen

1). Address review comment #13.
2). Add r=kchen after r+.
Attachment #778298 - Attachment is obsolete: true
Attachment #780174 - Flags: review+
Created attachment 780175 [details] [diff] [review]
Part 4: Fix xpcshell tests, v1, r=hsinyi

Add r=hsinyi after r+.
Attachment #778300 - Attachment is obsolete: true
Attachment #780175 - Flags: review+
Created attachment 780179 [details] [diff] [review]
Part 5: Marionette tests for cdma registration information, v2, r=hsinyi

1). Rebase.
2). Add r=hsinyi after r+.
Attachment #778301 - Attachment is obsolete: true
Attachment #780179 - Flags: review+
try server: https://tbpl.mozilla.org/?tree=Try&rev=7f5224ad19eb
https://hg.mozilla.org/projects/birch/rev/65d019d4162c
https://hg.mozilla.org/projects/birch/rev/59298610ee48
https://hg.mozilla.org/projects/birch/rev/1a6b938e93fd
https://hg.mozilla.org/projects/birch/rev/734ab44f2204
https://hg.mozilla.org/projects/birch/rev/db22940c0cba
Whiteboard: [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/65d019d4162c
https://hg.mozilla.org/mozilla-central/rev/59298610ee48
https://hg.mozilla.org/mozilla-central/rev/1a6b938e93fd
https://hg.mozilla.org/mozilla-central/rev/734ab44f2204
https://hg.mozilla.org/mozilla-central/rev/db22940c0cba
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.