883048 - [MMI] Send a ussd code while in airplane mode is allowed and doesn´t show any notification

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in Leo device with:

ril01.01.00.019.117
Gecko: b518de015ff9d28c7a59a9f1e799fc0ec688024e
Gaia: ea18de80fd04110756becaed214656642388401d

STR:
1-Enable airplane mode
2-Dial *321#

Expected result --> Some kind of notification to the user should be shown, indicating calls cannot be stablished with airplane mode on

Actual result --> USSD is sent and then generic failure is shown

Comment 1

[Wayne Chang [:wchang]]

Can we display the same error as if we're trying to make a phone call in airplane mode?

Some phones use the same prompt for both USSD and phone call cases in airplane mode.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Sure, we can do that. I'd like to fire this error from the platform though, so I'll need bug 883178 before.

Comment 3

[Wayne Chang [:wchang]]

Hi Fernando, can we move on this bug now that bug 883178 is done ;)

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Yes. However, I'd like to say in advance that there are MMI codes that are supposed to be allowed even in airplane mode (i.e. get IMEI, or any device specific MMI code). We don't know in advance if the MMI request involves a network connection, so we need to send it to the RIL and show the result in the MMI screen. All that we can do is to substitute the "Generic Failure" message error for a "Radio not available" one.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Untested patch

Comment 6

[Wayne Chang [:wchang]]

Hi Fernando,
That sounds fair. I think we should replce it when RIl throws an error while airplane mode is enabled. In case where airplane mode is disabled, keep whatever prompt we currently have. Does that sound right?

When can we expect a patch ready? Thanks!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 772047 [details] [diff] [review]
v1

Review of attachment 772047 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +2233,5 @@
> +    // If we couldn't parse the MMI code, we'll send it as an USSD request.
> +    if (mmi === null) {
> +      if (!_isRadioAvailable(MMI_KS_SC_USSD)) {
> +        return;
> +      }

Should move this if-block into |if (this._ussdSession)|.

Comment 9

[Anshul]

Fernando, is there a Gaia change to show this error?

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

http://hg.mozilla.org/projects/birch/rev/972a7b140ddd

No, there is no need for a Gaia patch.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/972a7b140ddd

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/282b5c37cf8d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/282b5c37cf8d