[SMS][MMS] One contact with very long name can be scrolled in recipient field

RESOLVED FIXED in Firefox OS v1.1hd

Status

Firefox OS
Gaia::SMS
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pyang, Assigned: rwaldron)

Tracking

unspecified
1.1 QE3 (26jun)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18+ verified, b2g-v1.1hd fixed)

Details

(Whiteboard: leorun3)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
PREREQUISITES:
    Several contacts saved with long name and surname
STEP:
    Open SMS app
    Tap on new to create a new MMS(attach a file)
    Tap on '+' icon to add a recipient
    Select one of those contacts with long name and surname
    Add another contact, then scroll comes back

EXPECT:
    One contact could be scrolled when it's really long
ACTUAL:
    Cursor moves to next line, but user can't scroll and see the contact just typed.
Hi Paul, could you add a snapshot of the scenario? Thanks!
(Assignee)

Comment 2

5 years ago
Borja, I can reproduce this. We currently dont allow pull down when there is only one contact or one line of contacts—this is a problem when one contact takes up enough room to qualify as it's own line.
(Assignee)

Comment 3

5 years ago
Needs scrollHeight
Assignee: nobody → waldron.rick
(Assignee)

Comment 4

5 years ago
Created attachment 763738 [details] [review]
Pull request on github
Attachment #763738 - Flags: review?(fbsc)
(Assignee)

Comment 5

5 years ago
Requesting leo+ as this improves the user interaction experience
blocking-b2g: --- → leo?
(Assignee)

Updated

5 years ago
Summary: [SMS/MMS] One contact with very long name can be scrolled in recipient field → [SMS][MMS] One contact with very long name can be scrolled in recipient field
(Assignee)

Updated

5 years ago
Attachment #763738 - Flags: review?(fbsc) → review?(gnarf37)

Comment 6

5 years ago
Comment on attachment 763738 [details] [review]
Pull request on github

r=me
Attachment #763738 - Flags: review?(gnarf37) → review+
(Assignee)

Comment 7

5 years ago
Landed https://github.com/mozilla-b2g/gaia/commit/ef031421fe8d4257fe198112b52d4d963a828498
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Triage - this would be a nice addition but only if the patch is safe. Rick, can you comment on the risk?
tracking-b2g18: --- → +
Flags: needinfo?(waldron.rick)
(Assignee)

Comment 9

5 years ago
(In reply to Wayne Chang [:wchang] from comment #8)
> Triage - this would be a nice addition but only if the patch is safe. Rick,
> can you comment on the risk?

Very low risk.

I'd say none, but that's not allowed in software development ;)
Flags: needinfo?(waldron.rick)

Updated

5 years ago
blocking-b2g: leo? → leo+
Target Milestone: --- → 1.1 QE3 (24jun)

Updated

5 years ago
Whiteboard: leorun3
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  ef031421fe8d4257fe198112b52d4d963a828498
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(waldron.rick)
(Assignee)

Comment 11

5 years ago
If every patch is conflicting, I think something went to v1-train too soon?


https://bugzilla.mozilla.org/show_bug.cgi?id=881248
https://bugzilla.mozilla.org/show_bug.cgi?id=882899
https://bugzilla.mozilla.org/show_bug.cgi?id=883058
Flags: needinfo?(waldron.rick) → needinfo?(jhford)
Uplifted ef031421fe8d4257fe198112b52d4d963a828498 to:
v1-train: 444fd0f5b9e43dffd76cdf4c775450eb91c9d61d
status-b2g18: --- → fixed
v1.1.0hd: 444fd0f5b9e43dffd76cdf4c775450eb91c9d61d
status-b2g-v1.1hd: --- → fixed

Comment 14

5 years ago
Varified,fixed on Leo Mozilla RIL.
Environmental Variables
Build ID: 20130716070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/629020cf576b
Gaia: fb9362d34260771d4a00b9a0e10a6bbad397bd3b
Platform Version: 18.1
RIL Version: 01.01.00.019.158

Verified User can now scroll the contact when it's really long.
status-b2g18: fixed → verified
Flags: needinfo?(jhford)
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.