883058 - [SMS][MMS] One contact with very long name can be scrolled in recipient field

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Paul Yang [:pyang] (away)]

PREREQUISITES:
    Several contacts saved with long name and surname
STEP:
    Open SMS app
    Tap on new to create a new MMS(attach a file)
    Tap on '+' icon to add a recipient
    Select one of those contacts with long name and surname
    Add another contact, then scroll comes back

EXPECT:
    One contact could be scrolled when it's really long
ACTUAL:
    Cursor moves to next line, but user can't scroll and see the contact just typed.

Comment 1

[Borja Salguero [:borjasalguero]]

Hi Paul, could you add a snapshot of the scenario? Thanks!

Comment 2

[Rick Waldron [:rwaldron]]

Borja, I can reproduce this. We currently dont allow pull down when there is only one contact or one line of contacts—this is a problem when one contact takes up enough room to qualify as it's own line.

Comment 3

[Rick Waldron [:rwaldron]]

Needs scrollHeight

Comment 4

[Rick Waldron [:rwaldron]]

Attachment: Pull request on github

Comment 5

[Rick Waldron [:rwaldron]]

Requesting leo+ as this improves the user interaction experience

Comment 6

[Corey Frang [:gnarf]]

Comment on attachment 763738 [details] [review]
Pull request on github

r=me

Comment 7

[Rick Waldron [:rwaldron]]

Landed https://github.com/mozilla-b2g/gaia/commit/ef031421fe8d4257fe198112b52d4d963a828498

Comment 8

[Wayne Chang [:wchang]]

Triage - this would be a nice addition but only if the patch is safe. Rick, can you comment on the risk?

Comment 9

[Rick Waldron [:rwaldron]]

(In reply to Wayne Chang [:wchang] from comment #8)
> Triage - this would be a nice addition but only if the patch is safe. Rick,
> can you comment on the risk?

Very low risk.

I'd say none, but that's not allowed in software development ;)

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  ef031421fe8d4257fe198112b52d4d963a828498
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 11

[Rick Waldron [:rwaldron]]

If every patch is conflicting, I think something went to v1-train too soon?


https://bugzilla.mozilla.org/show_bug.cgi?id=881248
https://bugzilla.mozilla.org/show_bug.cgi?id=882899
https://bugzilla.mozilla.org/show_bug.cgi?id=883058

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted ef031421fe8d4257fe198112b52d4d963a828498 to:
v1-train: 444fd0f5b9e43dffd76cdf4c775450eb91c9d61d

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 444fd0f5b9e43dffd76cdf4c775450eb91c9d61d

Comment 14

[dkumar]

Varified,fixed on Leo Mozilla RIL.
Environmental Variables
Build ID: 20130716070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/629020cf576b
Gaia: fb9362d34260771d4a00b9a0e10a6bbad397bd3b
Platform Version: 18.1
RIL Version: 01.01.00.019.158

Verified User can now scroll the contact when it's really long.