883114 - Cleanup various manual test make rules

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: various in dom

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: dom/workers/test/subdir

Moving files that should end up in a subdir, into a subdir.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: double-testing in crashreporter

As mentioned on IRC, we run those twice right now.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: toolkit/content/tests

A change from installing those shared files from the dir they come from, to the dir they should end up in.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part e: toolkit/content/tests/chrome/rtl*

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 762636 [details] [diff] [review]
Part a: various in dom

Review of attachment 762636 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/dom-level2-html/files/applets/org/w3c/domts/Makefile.in
@@ +12,5 @@
> +
> +MOCHITEST_FILES := \
> +  DOMTSApplet.class \
> +  $(NULL)
> +

I wish we didn't have to have a separate Makefile to make this rule work. Maybe we can fix this when we move this all to manifests or whatever.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 762642 [details] [diff] [review]
Part c: double-testing in crashreporter

Turns out this breaks stuff \o/

https://tbpl.mozilla.org/?tree=Try&rev=91faa4d5d23b

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/fe855688d0b8
https://hg.mozilla.org/mozilla-central/rev/85e3518c74a7
https://hg.mozilla.org/mozilla-central/rev/78746bdf4538
https://hg.mozilla.org/mozilla-central/rev/bdeb770d63e7

Will deal with part c elsewhere.