883150 - add tsvgx and tscrollx to talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

these tests need definitions and tsvgx needs code.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add tsvgx and tscrollx to talos (1.0)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

after landing this and adding the graph server definitions in bug 883137, we will need to:
* deploy graph server changes to production and staging
* add support for this in buildbot-configs
* deploy new page set to bm-remote (android)
* run staging tests
* profit

Comment 3

[Avi Halachmi (:avih)]

I think I'd have preferred a different implementation - one which doesn't duplicate all the files of a test, and calls it testx.

The only technical difference between the x version and the normal version is that we set a specific preference before running the test - while all the source files are identicsal. That's true for tscroll, and for tsvg it depends if the patch bug 854746 landed or not. tsvgx is identical to the patched tsvg from bug 854746, with a specific pref set before the run.

For tsvgx I might not mind so much (other than losing the repo history) since we'll deprecate the old tsvg anyway. But with tscroll/x, we'll be using them both, and any change made to one of them would have to be duplicated to the other. So I think it'd be much better to somehow run the same files twice, under different names, where the x version also sets the pref.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

tscroll files are identical, I just modified the preference.  For tsvg since the files themselves are modified, I created a new test called tsvgx.  We cannot run files side by side that change things without duplicating the files !

Comment 5

[Avi Halachmi (:avih)]

Comment on attachment 762672 [details] [diff] [review]
add tsvgx and tscrollx to talos (1.0)

Review of attachment 762672 [details] [diff] [review]:
-----------------------------------------------------------------

Just use |hg cp tsvg tsvgx| to keep repo history of tsvg at tsvgx, and then apply the patch. Sorry for not noticing that tscrollx didn't involve any copied files.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add tsvgx and tscrollx to talos (2.0)

updated patch using 'hg cp' to seed the svgx/ folder.

Comment 7

[Jeff Hammel]

Comment on attachment 762753 [details] [diff] [review]
add tsvgx and tscrollx to talos (2.0)

lgtm

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

deployed:
http://hg.mozilla.org/build/talos/rev/8cf5b862d113

Comment 9

[Matt Brubeck (:mbrubeck)]

I added some basic info and links to the developer docs here:
https://wiki.mozilla.org/Buildbot/Talos/Tests

They still need a real description from someone who understands these benchmarks well.