Closed Bug 883311 Opened 6 years ago Closed 6 years ago

Add Tab List implementation for the remote debugger

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 24.0

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

Aside from the main process, the remote debugger supports "tabs", which in Firefox are the real window tabs. I think the closest we can get to this is to provide access to the content windows inside <browser> elements.
Attached patch Fix - v1 β€” β€” Splinter Review
Attachment #762839 - Flags: review?(mconley)
Comment on attachment 762839 [details] [diff] [review]
Fix - v1

Review of attachment 762839 [details] [diff] [review]:
-----------------------------------------------------------------

This is really straight-forward. Thanks Philipp.

Just some formatting nits, and maybe use a Set checkedWindows instead of an Array.

::: mail/components/debugger/content/dbg-mail-actors.js
@@ +61,5 @@
> +  _mustNotify: false,
> +  _listeningToMediator: false,
> +
> +  // These windows should be checked for browser elements
> +  checkedWindows: ["mail:3pane", "mail:messageWindow"],

If we're going to store _actorByBrowser as a Map, we might as well go the full nine yards and store checkedWindows as a Set.  Then use checkedWindows.has() instead of indexOf > -1.

@@ +64,5 @@
> +  // These windows should be checked for browser elements
> +  checkedWindows: ["mail:3pane", "mail:messageWindow"],
> +
> +  get onListChanged() {
> +      return this._onListChanged;

2 space indentation please

@@ +76,5 @@
> +    this._checkListening();
> +  },
> +
> +  _checkListening: function() {
> +   let shouldListenToMediator =

2 space indentation
Attachment #762839 - Flags: review?(mconley) → review+
Pushed to comm-central changeset a17d8582694a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
All comments taken care of, I went with the Set.
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.