Open
Bug 883538
Opened 11 years ago
Updated 2 years ago
Install IPDL headers into dist/include
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
NEW
People
(Reporter: Ms2ger, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.90 KB,
patch
|
gps
:
feedback-
|
Details | Diff | Splinter Review |
Instead of adding $(DEPTH)/ipc/ipdl/_ipdlheaders to LOCAL_INCLUDES every time we want to use them.
Attachment #763117 -
Flags: review?(gps)
Reporter | ||
Comment 1•11 years ago
|
||
Comment on attachment 763117 [details] [diff] [review]
Patch v1
Hrm, I think this actually makes us regenerate the headers and rebuild the world every top-level build... f? to see if you have a better idea
Attachment #763117 -
Flags: review?(gps) → feedback?(gps)
Comment 2•11 years ago
|
||
Comment on attachment 763117 [details] [diff] [review]
Patch v1
Review of attachment 763117 [details] [diff] [review]:
-----------------------------------------------------------------
If I am reading things correctly and my local build can be trusted, we don't currently copy ipdl headers into dist/include. So, this is a change in behavior and thus not warranted.
The ipdl files already have weird (read: bad) dependency foo going on. See bug 629668. After ipdl have moved into moz.build (bug 868536), we should completely overhaul the rules so things are sane. If you are going to touch ipdl make foo, I think I'd rather you start there. I have a build-ipdl patch in my patch queue that starts this work. Surely it's been bit rotted by other moz.build conversions.
Attachment #763117 -
Flags: feedback?(gps) → feedback-
Comment 3•11 years ago
|
||
Note: if we end up installing ipdl headers into dist/include (or some similar already included path), we can probably remove the GeneratedInclude stuff from moz.build added in bug 928709.
Reporter | ||
Updated•9 years ago
|
Assignee: Ms2ger → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•