Install IPDL headers into dist/include

NEW
Unassigned

Status

()

Core
IPC
5 years ago
3 years ago

People

(Reporter: Ms2ger, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 763117 [details] [diff] [review]
Patch v1

Instead of adding $(DEPTH)/ipc/ipdl/_ipdlheaders to LOCAL_INCLUDES every time we want to use them.
Attachment #763117 - Flags: review?(gps)
(Reporter)

Comment 1

5 years ago
Comment on attachment 763117 [details] [diff] [review]
Patch v1

Hrm, I think this actually makes us regenerate the headers and rebuild the world every top-level build... f? to see if you have a better idea
Attachment #763117 - Flags: review?(gps) → feedback?(gps)

Comment 2

5 years ago
Comment on attachment 763117 [details] [diff] [review]
Patch v1

Review of attachment 763117 [details] [diff] [review]:
-----------------------------------------------------------------

If I am reading things correctly and my local build can be trusted, we don't currently copy ipdl headers into dist/include. So, this is a change in behavior and thus not warranted.

The ipdl files already have weird (read: bad) dependency foo going on. See bug 629668. After ipdl have moved into moz.build (bug 868536), we should completely overhaul the rules so things are sane. If you are going to touch ipdl make foo, I think I'd rather you start there. I have a build-ipdl patch in my patch queue that starts this work. Surely it's been bit rotted by other moz.build conversions.
Attachment #763117 - Flags: feedback?(gps) → feedback-
Note: if we end up installing ipdl headers into dist/include (or some similar already included path), we can probably remove the GeneratedInclude stuff from moz.build added in bug 928709.
(Reporter)

Updated

3 years ago
Assignee: Ms2ger → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.