Closed Bug 883673 Opened 12 years ago Closed 11 years ago

[BB][Headers] RTL is messed up

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nefzaoui, Assigned: nefzaoui)

References

Details

(Whiteboard: [rtl-meta])

Attachments

(2 files, 3 obsolete files)

RTL Headers after patch
86.07 KB, image/png
Details
Pull Request to proposed patch
46 bytes, text/x-github-pull-request
kaze
: review+
Details | Review
User Agent: Mozilla/5.0 (Windows NT 6.2; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release) Build ID: 20130511120803 Steps to reproduce: All the apps are affected by this bug, which is when using an RTL-language (Arabic), headers are messed up
Thanks Ahmed for re-opening this discussion, there is an old patch that still not merged if it can help ! bug 834464 I think that you also worked on the headers issue right ?
Yes I worked on them before but to be more specific, The right thing was to open a bug for all headers, since all the apps are affected by this bug, while the other one is meant for Settings.. And for the patch of bug 834464 Yes it really needs to be merged ASAP if it's confirmed as fixing the bug itself..
Attached file Patch making RTL headers bug free (obsolete) —
Attachment #771502 - Attachment mime type: text/plain → text/html
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: gaia-rtl
Attachment #771502 - Attachment is obsolete: true
Attached file PR to Github (obsolete) —
A much more mature patch fixing all the bugs appearing on Headers in RTL mode. With the minimum possible of additions.
Attachment #824126 - Flags: review?(kaze)
Since bug 925929 seems to be ready, should I make changes for this comment to suit up with it?
Flags: needinfo?(kaze)
Attached image RTL Headers after patch —
Attachment #824126 - Attachment is obsolete: true
Attachment #824126 - Flags: review?(kaze)
Attached file RTL Headers' fix (obsolete) —
Since headers' visual refresh has landed. This is the new patch. :)
Attachment #8339343 - Flags: review?(kaze)
Attachment #8339343 - Attachment is obsolete: true
Attachment #8339343 - Flags: review?(kaze)
Attachment #8357706 - Flags: review?(kaze)
Comment on attachment 8357706 [details] [review] Pull Request to proposed patch LGTM but please address my comment on github. Thanks for your good work!
Attachment #8357706 - Flags: review?(kaze) → review+
Flags: needinfo?(kaze)
Comment on attachment 8357706 [details] [review] Pull Request to proposed patch Pavel: could you please review this patch? On second thought I’m not really sure this patch is as safe as I expected.
Attachment #8357706 - Flags: review?(pivanov)
BTW, I just added the PR by kaze to my PR's branch, it should be fine now And sorry for delay :)
(In reply to Fabien Cazenave [:kaze] from comment #11) > Pavel: could you please review this patch? On second thought I’m not really > sure this patch is as safe as I expected. Ooops, forget the nonsense. The patch makes perfect sense to me — sue me if bad things happen.
Thanks a lot Ahmed!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee: nobody → nefzaoui.ahmed
Mass Edit: adding the [rtl-meta]
Whiteboard: [rtl-meta]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: