883705 - [Cost Control]In Usage Graph Wi-Fi Toggle is always unchecked after closing the Usage app and again Reopen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

Description

[Leo]

1. Title : In Usage Graph Wi-Fi Toggle is always unchecked after closing the Usage app and again Reopen.
2. Precondition : Usage->Wi-Fi Toggle ON
3. Tester's Action : Close the Usage app and again reopen it.
4. Detailed Symptom (ENG.) :when data graph is FIRST SEEN after setup flow: Wifi usage toggle should be OFF and once the user checked the wi-fi toggle it should  maintain it state even after closing the Usage app.But it is always unchecked.
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 0c836be7f24693b74ad7fd21c8153824f1c7f548
9.Personal email id: [e-mail]

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for this bug

use asyncStorage to save the state of user's choice.

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 763466 [details]
patch for this bug

Check comments on GitHub, please.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 763466 [details]
patch for this bug

Sorry, I am a stupid guy. The console.log line should be removed. I missed that.

I had changed the code according to comments, ran gjslint, and ran unit tests. Please review it again. Thanks.

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 763466 [details]
patch for this bug

Not stupid at all. Thank you very much for the quick fix. Please, review the latest nit before merge and ping me when done.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Salvador, 

I had fixed the code according to your comment. Please see it before I merge it.

Comment 6

[Salvador de la Puente González [:salva]]

It seems ok, good work. Let's close this.
Master: 016a92d86d3b9afb264ea350ad93ef8e687cf7b0

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 016a92d86d3b9afb264ea350ad93ef8e687cf7b0 to:
v1-train: 82f1f0ad49f529f336266493b7a8944584485242

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: 82f1f0ad49f529f336266493b7a8944584485242