Closed Bug 883787 Opened 11 years ago Closed 11 years ago

[Call log] Not translate "Add new number" menu

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
RESOLVED FIXED
Milestone:
1.1 QE3 (26jun)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: leo.bugzilla.gaia, Assigned: rik)

References

Details

(Whiteboard: [TD-44891])

Attachments

(2 files, 1 obsolete file)

Not translate
13.21 KB, image/png
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10678
358 bytes, text/html
kaze
: review+
Details
Attached image Not translate —
1. Title : Not translate "Add new number" menu 2. Precondition : Set language to English 3. Tester's Action : Settings >> Language >> Change language from English to Espanol >> Run Dialer >> Enter call log >> Select number 4. Detailed Symptom : Not translate token 5. Expected : Translate token 6. Reproducibility: Y 1) Frequency Rate : 100% 7. Gaia Revision : 4d10e1297b859cacc174c0a54af61a7678d7c32d 8. Personal email id : promise09th@gmail.com
blocking-b2g: leo? → leo+
Priority: -- → P2
Target Milestone: --- → 1.1 QE3 (24jun)
Whiteboard: [TD-44891]
Assignee: nobody → anthony
Blocks: 883821
I can't reproduce this on v1-train. Maybe you have old "es" strings?
I can reproduce this on v1-train. I try France language. Gaia commit : c507ff65b51194383da65f8927164f078a3e1f79 Path : 1. Build all gaia. (GAIA_DEFAULT_LOCALE=fr) 2. Download gaia to device 3. Set language to English 4. Run dialer once, and then end dialer app. 5. Set language to France 6. Run dialer app, and move to call log. 7. Select number This issue occurs not only "es" but also other language. I think this problem relates with GAIA_DEFAULT_LOCALE value. When I build using GAIA_DEFAULT_LOCALE=en-us, it is not reproduced this issue. Please check this issue.(Please build using other language)
I can see that now. Simpler steps to reproduce: 1) Build and install gaia with GAIA_DEFAULT_LOCALE=fr 2) Run dialer app 3) Open call log 4) Select a number
If you then go to Settings, switch to English and go back to French in one step, you won't see the bug.
Pointer to Github pull-request
Attachment #766023 - Flags: review?(21)
Attachment #766023 - Flags: review?(21) → review?(poirot.alex)
Comment on attachment 766023 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10541 See various nits in pull request, but looks good and works fine.
Attachment #766023 - Flags: review?(poirot.alex) → review+
https://github.com/mozilla-b2g/gaia/compare/e9dbb1134dd8...9780e0f09a34 in master
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
This bug was partially uplifted. Uplifted 53eea8a3da5ae1de3de471a0b1d48aafdd7e81ce to: v1-train: b2b19ae237adecbc91faf99c6f0372110ad7f44e Commit 9780e0f09a3415af2430348753fa3c86b7dbac78 didn't uplift to branch v1-train
9780e0f09a3415af2430348753fa3c86b7dbac78 is the merge commit. I don't think it needs uplifting. Needinfo-ing John to make sure.
Flags: needinfo?(jhford)
Ahh, thanks. If that's the case, then I think we're fine here. I pushed a backout before seeing your comment or commenting on the bug, so I've relanded with: v1-train: ff8551b
Flags: needinfo?(jhford)
1.1hd: ff8551ba2d5a73eb3e90fa6fc9b3a9feaa0aa7d9
status-b2g18: --- → fixed
status-b2g-v1.1hd: --- → fixed
This broke the sms app in bug 887614. So I'll backout and just call l10n.translate on the new inserted elements.
Blocks: 887614
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Backed out from master with https://github.com/mozilla-b2g/gaia/commit/7af52f9e69890613c5b9daedb115ef484836ce1b because of bug 887614. John: Do you want to do the backouts for v1-train and 1.1hd?
Flags: needinfo?(jhford)
Attachment #766023 - Attachment is obsolete: true
Attachment #768473 - Flags: review?(kaze)
Comment on attachment 768473 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10678 Nice. Thanks for your time Anthony, sorry we had to back-out.
Attachment #768473 - Flags: review?(kaze) → review+
Backouts on branch: [v1-train 42f4789] [v1.1.0hd 44eb219]
status-b2g18: fixed → ?
status-b2g-v1.1hd: fixed → ?
Flags: needinfo?(jhford)
v1.1.0hd: 42f47890fe4987006130a1bee8358c050325517b
status-b2g-v1.1hd: ? → fixed
don't exactly know why v1.1.0hd has 2 commits for the same revert, but well, the new patch will need to land there. John I think you have a bug in your script for this case. (needinfo to be sure you see this, no action is necessary for this bug as of now)
status-b2g-v1.1hd: fixed → affected
Flags: needinfo?(jhford)
Landed in master: aa2676c1a79de4ee21664abf78bae97645cf83ae
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 aa2676c1a79de4ee21664abf78bae97645cf83ae <RESOLVE MERGE CONFLICTS> git commit
Flags: needinfo?(anthony)
Merged in v1-train with 5ad81c0d061761519a97e1ae83481740864c5ff6.
status-b2g18: affected → fixed
Flags: needinfo?(anthony)
v1.1.0hd: 5ad81c0d061761519a97e1ae83481740864c5ff6
status-b2g-v1.1hd: affected → fixed
v1.1.0hd: 44eb21960b9bf50755fcb2ade8b25ae0c0d47bb5
Flags: needinfo?(jhford)
v1.1.0hd: 44eb21960b9bf50755fcb2ade8b25ae0c0d47bb5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: