Closed Bug 887614 Opened 11 years ago Closed 11 years ago

Attachments in composer must show size

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: gnarf, Assigned: gnarf)

References

Details

(Keywords: regression)

Attachments

(2 obsolete files)

Per https://bugzilla.mozilla.org/show_bug.cgi?id=873758#c28: The size is no longer displayed on attachments in the Composer
Flags: needinfo?(dietrich)
Attached file patch v1 (obsolete) —
* Something sanitizes the <body> tag on the device, so switch to putting the container classes on a div
Attachment #768128 - Flags: review?(felash)
kaze, do you have an idea of what could be stripping the <head> </head> <body> and </body> tags from https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/index.html#L280-294 at build time ? It's easy to check in profile/webapps/sms.gaiamobile.org/application.zip that it's being removed, and I'd really want to find the cause reason rather than working around this.
Flags: needinfo?(kaze)
Confirmed, this regression is caused by bug 883787.
Keywords: regression
Attached file link to pull request (obsolete) —
https://github.com/mozilla-b2g/gaia/pull/10665 This fixes the issue caused by bug 873758, but maybe we should just backout it instead.
Attachment #768219 - Flags: review?(felash)
I just had a talk with Anthony, he’s going to back-out his patch and re-open bug 873758.
Depends on: 883787
Comment on attachment 768128 [details] patch v1 This was just a work around that won't be needed now.
Attachment #768128 - Attachment is obsolete: true
Attachment #768128 - Flags: review?(felash)
This was backed out so closing. Sorry for this.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(dietrich)
Resolution: --- → FIXED
Attachment #768219 - Attachment is obsolete: true
Attachment #768219 - Flags: review?(felash)
blocking-b2g: leo? → ---
Size is shown when attaching a file. Verified with unagi device 06/28 build: Gecko-db60841 Gaia-508cfc8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: