883822 - [SMS] The handset keeps displaying the keyboard even when back button on the Compose screen is clicked

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Leo]

1. Title:  The handset keeps displaying the keyboard even when back button  Compose screen is clicked
2. Precondition: One contact on Call Logs and Contact should be saved in contact app
3. Tester's Action:(1) Dial->Call Logs->Select a call log->Press the message icon
                   (2) Do not tip any letter on keyboard > Back
                   (3) Check the screen.
4. Detailed Symptom (ENG.) : The handset keeps displaying the keyboard on the screen.
5. Expected: The handset should not display the keyboard on the screen anymore.
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train and master
8. Gaia Revision:  20c8fb29caf13e5a4530ba5c7b837a849c79c91b
9. Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Screenshot attached

Please find the screenshot attached for this issue

Comment 2

[Paul Yang [:pyang] (away)]

Precondition:
- At least 1 contact with phone number
- Message app is not launched

STR:
1. Open contact app
2. Tap on contact with phone number
3. Tap "send message" icon on the right side of the phone number
4. Automatically transit to message app
5. Press back button

Comment 3

[Wayne Chang [:wchang]]

Anthony, are you working on this?

Comment 4

[Anthony Ricaud (:rik)]

I reproduced it earlier this week but can't reproduce anymore. I believe this was fixed by bug 878735. And this was uplifted to v1-train.

Feel free to re-open if you're still seeing this with a build containing the patch from bug 87835.

Comment 5

[Leo]

I also think bug 878735 will solve it, the root cause was the focus.
now in bug 878735 patch we are explicitly requesting focus to recipient list.

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

There doesn't seem to be any resolving code here o_O

Comment 7

[isabelrios]

This is still happening as described on comment 2 and shown on the attachment. Reopening

Unagi v1-train build:
Gecko-96c693c
Gaia-0d5a9a7

Comment 8

[Anthony Ricaud (:rik)]

Unassigning myself as I'll be on PTO starting tomorrow.

Comment 9

[Leo]

The patch works well on leo

Comment 10

[Julien Wajsberg [:julienw]]

Isabel, could you please to reproduce this again ?

Comment 11

[isabelrios]

Hi Julien,

Yes, I see it with 07/07 v1-train build: 
Gecko-e7708d4
Gaia-d336288

Comment 12

[Alex Keybl [:akeybl]]

Julien, please email us if you don't believe this will hit the 7/15 date.

Comment 13

[Julien Wajsberg [:julienw]]

giving this to kaze who has some free cycles

Comment 14

[Fabien Cazenave [:kaze]]

Attachment: link to pull request

https://github.com/mozilla-b2g/gaia/pull/10979

Comment 15

[Corey Frang [:gnarf]]

Comment on attachment 775663 [details]
link to pull request

Code looks good, just waiting for a clean pass in the unit suite - Please request review again after update!  Thanks!

Comment 16

[Corey Frang [:gnarf]]

Comment on attachment 775663 [details]
link to pull request

All fixed - Units are good - r=me

Comment 17

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/e8ae64883ab17ab8c3ff1fe44b346f8456b315c4
v1-train: https://github.com/mozilla-b2g/gaia/commit/d17ada15640c4e926693a7f43110ca1e5577c73d

Comment 18

[Corey Frang [:gnarf]]

Note: there is a followup commit for tests a=npotb:

master: https://github.com/mozilla-b2g/gaia/commit/2cff2fbbf3c70f410a50c59c141333052e7ae2b3
v1-train: https://github.com/mozilla-b2g/gaia/commit/773a197b4e18377f366a0815778789aa4f25d412

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 773a197b4e18377f366a0815778789aa4f25d412
v1.1.0hd: d17ada15640c4e926693a7f43110ca1e5577c73d

Comment 20

[isabelrios]

Cannot reproduce this issue with latest unagi v1-train build:
Gecko-f94f793
Gaia-ef03c2b
ref ril

Verified.

Comment 21

[Leo]

Bug 878735 will solve this issue, the root cause was the focus.
now in bug 878735 patch we are explicitly requesting focus to recipient list.

So we have not taken this patch because 878735 already solved the issue.

Comment 22

[Julien Wajsberg [:julienw]]

Leo, see comment 11: strangely, this does not seem to be fixed by the fix in bug 878735 ?

Comment 23

[Leo]

Hi Julien,
But the issue is not reproducible after applying the patch.

(In reply to Julien Wajsberg [:julienw] (PTO 15th -> 28th July) from comment #22)
> Leo, see comment 11: strangely, this does not seem to be fixed by the fix in
> bug 878735 ?

Comment 24

[Julien Wajsberg [:julienw]]

I think you should not diverge from our v1-train branch, this will make bug solving harder...

Comment 25

[Leo]

Hi Julienw,

We have tested and took the patch.

Thanks,