883829 - When the handset receives a notification in Portuguese, the relative time is cut

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Leo]

1. Title: when the handset receives a notification, the notification is not displayed correctly.
2. Precondition: Settings -> Language -> Select Portugues
3. Tester's Action:(1)On idle screen receive a SMS and check the Notifications Panel. 
                   (2)In Sleep Mode receive a SMS and Check the popup.
4. Detailed Symptom (ENG.) : In both cases when the handset receives a notification, the notification is not displayed correctly
5. Expected: In both cases the notifications should displayed normally.
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train and master
8. Gaia Revision:  1aed138dfef6279a00475f51ce0c491f32799ab6
9. Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: SMS Screenshots attached.

Comment 2

[Anthony Ricaud (:rik)]

I can't reproduce this on v1-train or master. This looks like a locale properties file issue, maybe the build you're using has old pt-BR strings?

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Could you kindly help us check two things ?
1. same issue with other language ? Chineses or france

2. please check date.(pt-BR ?).properties file under shared/locales/date folder , see if it's latest one as below source

http://hg.mozilla.org/gaia-l10n/

Comment 4

[Leo]

In the latest version of leo, its not showing as "{[ plural". Its showing the localized value. But now the issue is in english its showing "just now" properly, but for portugese language "há pouco" is not shown completely but ellipsized.

Also for minute representation english show "1m ago" but for portugese its showing "1min atrás" again ellipsized.

can we have a shorter string in this case?

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Please refer to bug 881111.
The pt-BR.properties file under shared/locales/date might be not updated.

Comment 6

[Beatriz Rodríguez [:brg]]

Adding in cc people from l10n team to know the status and if they can help.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 763515 [details]
SMS Screenshots attached.

Marking the screenshots as obsolete based on the comments that this particular artifact can't be reproduced.

It'd be helpful to get a screenshot of the current behavior. Even more helpful if it's not a zip, so that one can directly look at it in bugzilla.

Comment 8

[Axel Hecht [:Pike]]

CCing Fernando, too.

It might very well be that we'll need a code change in gaia to allow for more visual room than just the counted pixels of "Just now", though.

Comment 9

[Dietrich Ayala (:dietrich)]

Fernando, can you help to answer the question in comment #8? Thank you!

Comment 10

[Leo]

Attachment: Screenshots attached

Comment 11

[Leo]

Attachment: Screenshots attached

Comment 12

[Leo]

Attachment: Screenshots attached

Comment 13

[Axel Hecht [:Pike]]

Thanks for the screenshots.

This should be fixed on the code side, we're replacing two characters 'co' with an ellipsis.

The layout should allow for some additional space compared to en-US.

This problem should reproduce on at least Spanish, Polish, and German.

Comment 14

[Anthony Ricaud (:rik)]

I'm not sure how to fix this. If we add more space for the relative date, we'll have to reduce the part dedicated to the title of the notification, which I believe is more important than the relative date.

Maybe we could use a smaller font for this part of the notification?

Requesting UX input.

Comment 15

[Stephany Wilkes]

Reassigning to Ayman from the general FFOS-UX identity since SMS is his domain.

Comment 16

[Anthony Ricaud (:rik)]

It is actually not SMS specific, it affects all notifications both on the lockscreen and in the notification tray.

Changing the title and the component to reflect that.

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: Pointer to https://github.com/mozilla-b2g/gaia/pull/10657

Extend the length of timestamp string.

Comment 18

[Anthony Ricaud (:rik)]

Comment on attachment 768175 [details]
Pointer to https://github.com/mozilla-b2g/gaia/pull/10657

With this patch the notification title and the time will overlap when the title is long.

Comment 19

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 768175 [details]
Pointer to https://github.com/mozilla-b2g/gaia/pull/10657

Updated again, please check.

Comment 20

[ayman maat :maat]

passing back to [e-mail] as this is a notifications issue and therefore part of the system so outside my domain.

Comment 21

[Fernando Pereira Silveira]

sorry, I'm late...
I guess Leo's screenshots on comment #10, comment #11 and comment #12 answer the comment #8 question

Comment 22

[Dylan Oliver [:doliver]]

Rob - can you comment on the solution?

Comment 23

[Steve Chung [:steveck]]

Comment on attachment 768175 [details]
Pointer to https://github.com/mozilla-b2g/gaia/pull/10657

Reassign the reviewer to system app peer who has the authority to review the changes in system notification. But I sill left some comments on github(https://github.com/mozilla-b2g/gaia/pull/10657#issuecomment-20168524).

Comment 24

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 768175 [details]
Pointer to https://github.com/mozilla-b2g/gaia/pull/10657

css only change, r=me.

Comment 25

[Anthony Ricaud (:rik)]

Attachment: Screenshot with width changed

This is a screenshot with attachment 768175 [details] applied.

Comment 26

[Anthony Ricaud (:rik)]

Comment on attachment 768175 [details]
Pointer to https://github.com/mozilla-b2g/gaia/pull/10657

Based on attachment 768783 [details], I think we should not land this fix.

Comment 27

[Anthony Ricaud (:rik)]

Attachment: Screenshot with font-size changed

Here is a screenshot with the font-size and font-weight changed. I think this is still readable. We could maybe tweak the vertical alignment a bit too.

Comment 28

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10686

Pointer to Github pull-request

Comment 29

[Fernando Pereira Silveira]

attachment 768784 [details] looks good to me

Comment 30

[Rob MacDonald [:robmac]]

Comment on attachment 768786 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10686

I am unable to view the patch, but, assuming this is the same as attachment https://bug883829.bugzilla.mozilla.org/attachment.cgi?id=768784, then we're fine with the solution. (I'm also assuming that the space to the left of the notification is reserved for an icon.)

Comment 31

[Rob MacDonald [:robmac]]

Clearing needsinfo based on comment above.

Comment 32

[Anthony Ricaud (:rik)]

Merged in master with f05656aefc7c942e0b5dfce6de175c2e1b7742cf.

Comment 33

[Gareth Aye [:gaye] (back from PTO)]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 f05656aefc7c942e0b5dfce6de175c2e1b7742cf
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 34

[Anthony Ricaud (:rik)]

Landed in v1-train with 0417587583a19dc52e24350052f4ce1195f0241c.