883909 - Remove twitter plugin

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Brett Gaylor [:brett]]

Since the API has been deprecated, tweets are no longer working. Let's remove the plugin till we have a solution.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/71

Lots of red.

I don't see the reason keeping it around in the repo, so I nuked it.

Another option is to disable it, and keep it in the repo.

I don't think deprecated is the right word for this, removed or deleted maybe?

Comment 2

[David Humphrey (:humph)]

Comment on attachment 765526 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/71

Matt, can you help out with a review here?  Jon seems to have a few on him now.

Comment 3

[Matthew Schranz [:mjschranz]]

Comment on attachment 765526 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/71

R+ with nit.

This is good.

Comment 4

[Jon Buckley [:jbuck]]

Comment on attachment 765526 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/71

There's some loading optimizations you can do noted in the PR.

I also think it'd be a good idea to make `/templates/assets/plugins/twitter/popcorn.twitter.css` a completely empty file because otherwise all embeds will start getting 404s reported in the web console.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 765526 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/71

Updates. Matt if you get a chance to give it one final look over after the recent changes, go ahead.

Comment 6

[Jon Buckley [:jbuck]]

Comment on attachment 765526 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/71

Pretty close, just a little bit more requirejs cleanup needed

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 765526 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/71

Heh, my "additions" only worked before without the path because I forgot to remove the part in the embed and butter files.

Updated.

Comment 8

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/48cf6b05ae31719eeed7f88a88bdb8ee8b3f08b0