883965 - [Settings] Show the authentication type setting correctly in the APN setting form (follow-up bug 866003)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

I've noticed that for some carriers we might not show the authentication type settings correctly in the APN setting form.

See https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/carrier.js#L116.

This is a follow-up of bug 866003.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/10575

Kaze, this is a follow-up bug of bug 866003. Here we fix an issue I didn't notice during my tests (my fault, sorry). It causes the user might lose the authentication type setting when switching between different APN sets (in the case there are more than one APN set per MCC/MNC codes). Could you take a look please? Thanks!

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Here we fix an issue in the code we added for a leo+ blocker (bug 866003).

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 766660 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/10575

looks OK to me, see comment on PR

Comment 4

[Fabien Cazenave [:kaze]]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/81bbb91bb690cbe4052f33fca9b57186816b28ef

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 81bbb91bb690cbe4052f33fca9b57186816b28ef to:
v1-train: 249fedf657967738fc0bf54dff228aee54f4c09d

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 249fedf657967738fc0bf54dff228aee54f4c09d

Comment 7

[Deepa Subramanian]

The user is able to see Authentication Options on the UI (Not defined, None, PAP, CHAP, PAP or CHAP. Verified on Leo device build. 

Environmental Variables
Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1