884142 - [Settings] cancel button do not work in call waiting warning popup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Leo]

1. Title : cancel button do not work in call waiting warning popup
2. Precondition : No SIM
3. Tester's Action : Setting > Call Settings > Call Waiting > Cancel
4. Detailed Symptom : No action
5. Expected : Go to the previous menu
6. Reproducibility: Y
   - Frequency Rate : 100%
8. Version Info
Mozilla build ID: 20130526070207
Gaia Revision : 4d10e1297b859cacc174c0a54af61a7678d7c32d
Gecko Revision : 52341e43539a0e8b9aa77a9128cc3871439b8aa6

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This issue would only occur with Gaia v1-train since on Gaia master, we have Bug 869873 to disable the "Call settings" subpanal while SIM is absent.

Will try to evaluate whether we need to fix this issue "[Cancel] button not working" or uplift Bug 869873.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10552

Pointer to Github pull-request

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 766424 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10552

Hi Arthur,

This pull request is to uplift Bug 869873 for this issue.
I think this is the best way for now to minimize the diversity of Gaia master and v1-train.

[Root Cause]
In initCallWaiting(), we would attach the event handler for the [Cancel] button of the warning dialog (alertPanel in code).
However, it has a early return if the card state is not ready,
https://github.com/mozilla-b2g/gaia/blob/c411b04a85b0975077842b3cfb6f1ada9a355b7c/apps/settings/js/call.js#L507

So, the [Cancel], [Set] button would not work while SIM card is absent.


[Soultion]
Uplift 869873, so the user could not enter "Call Settings" subpanel when there is no SIM.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 766424 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10552

Uplifting 869873 is reasonable and safer. Thanks for taking care of this, Rudy!

Comment 5

[Leo]

Attachment: screenshot

Need to check about menu-item focus

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Arthur, thanks for your feedback.


Bug 869873 uplifted, 
Gaia v1-train
ffd437de6d09f26379dfde7a46beb849fd7188fa

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Leo from comment #5)
> Created attachment 766519 [details]
> screenshot
> 
> Need to check about menu-item focus

This issue could be reproduced on Gaia master/v1-train.
Since this issue has been set as resolved, we're going to open another bug for tracking.

Comment 8

[hyuna.cho]

I found a side-effect bug.

[Precondition]
SIM lock - enable

[Reprop]
Reboot - PIN code popup close without entering number - Go to Settings - Navigate SIM security - Can't select SIM security to disable SIM lock

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hyuna, what you pointed out is not a bug. Sim security panel is disabled when SIM card is not available. Even the panel is enabled, users still need to enter a correct password in order to turn off the sim lock.

Comment 10

[hyuna.cho]

(In reply to Arthur Chen [:arthurcc] OOO 6/25~6/29 MAE, Shanghai from comment #9)
> Hyuna, what you pointed out is not a bug. Sim security panel is disabled
> when SIM card is not available. Even the panel is enabled, users still need
> to enter a correct password in order to turn off the sim lock.

Then, user can only disable the sim lock using launch dialer/sms/contact apps.
These apps already blocked using telephony, sms permission.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

I see your point... you found an UX issue. :) Let's use bug 886758 to track it.