Closed
Bug 884279
Opened 11 years ago
Closed 11 years ago
renaming future to promise
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: baku, Assigned: baku)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 5 obsolete files)
72.50 KB,
patch
|
Details | Diff | Splinter Review |
Splitting bug 875289
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #764103 -
Flags: review?(mounir)
Comment 2•11 years ago
|
||
Comment on attachment 764103 [details] [diff] [review]
patch
Review of attachment 764103 [details] [diff] [review]:
-----------------------------------------------------------------
Please use `hg mv` for Future.webidl -> Promise.webidl.
::: modules/libpref/src/init/all.js
@@ +1821,5 @@
>
> // If true, ArchiveReader will be enabled
> pref("dom.archivereader.enabled", false);
>
> // If true, Future will be enabled
s/Future/Promise/
Attachment #764103 -
Flags: review?(mounir) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #764103 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 4•11 years ago
|
||
This doesn't apply cleanly on inbound since Promise.h does not exist there.
Keywords: checkin-needed
Assignee | ||
Comment 5•11 years ago
|
||
?!? Promise.h is a renaming of Future.h it's included in this patch.
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
Comment 8•11 years ago
|
||
Backed out because of build bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/6208332c8b04
Comment 9•11 years ago
|
||
Assignee | ||
Comment 10•11 years ago
|
||
Rebased on top of m-c and m-i
Attachment #764622 -
Attachment is obsolete: true
Attachment #765025 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 11•11 years ago
|
||
Keywords: checkin-needed
Assignee | ||
Comment 12•11 years ago
|
||
Backed out becuause of 885318
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/2266ccdba6d7
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5031737e46
Depends on: 885318
Comment 13•11 years ago
|
||
BTW, this patch has bug 875289 in the commit message. I fixed it when I pushed it the first time, but you need to fix it in your local queue before you push it again.
Assignee | ||
Comment 15•11 years ago
|
||
Attachment #767707 -
Attachment is obsolete: true
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 16•11 years ago
|
||
Keywords: checkin-needed
Comment 17•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•