renaming future to promise

RESOLVED FIXED in mozilla25

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

(Blocks: 1 bug)

Trunk
mozilla25
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

4 years ago
Splitting bug 875289
(Assignee)

Comment 1

4 years ago
Created attachment 764103 [details] [diff] [review]
patch
Attachment #764103 - Flags: review?(mounir)
Comment on attachment 764103 [details] [diff] [review]
patch

Review of attachment 764103 [details] [diff] [review]:
-----------------------------------------------------------------

Please use `hg mv` for Future.webidl -> Promise.webidl.

::: modules/libpref/src/init/all.js
@@ +1821,5 @@
>  
>  // If true, ArchiveReader will be enabled
>  pref("dom.archivereader.enabled", false);
>  
>  // If true, Future will be enabled

s/Future/Promise/
Attachment #764103 - Flags: review?(mounir) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 764622 [details] [diff] [review]
patch
Attachment #764103 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
This doesn't apply cleanly on inbound since Promise.h does not exist there.
Keywords: checkin-needed
(Assignee)

Comment 5

4 years ago
?!? Promise.h is a renaming of Future.h it's included in this patch.
(Assignee)

Comment 6

4 years ago
Created attachment 765025 [details] [diff] [review]
patch for m-i
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1596bee956c
Flags: in-testsuite-
Keywords: checkin-needed
Backed out because of build bustage: https://hg.mozilla.org/integration/mozilla-inbound/rev/6208332c8b04
(https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=6a4bbbbe19bb)
(Assignee)

Comment 10

4 years ago
Created attachment 765243 [details] [diff] [review]
patch

Rebased on top of m-c and m-i
Attachment #764622 - Attachment is obsolete: true
Attachment #765025 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 11

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/96036434bb78
Keywords: checkin-needed
(Assignee)

Comment 12

4 years ago
Backed out becuause of 885318

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/2266ccdba6d7
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5031737e46
Depends on: 885318
(Assignee)

Updated

4 years ago
Blocks: 885333
BTW, this patch has bug 875289 in the commit message. I fixed it when I pushed it the first time, but you need to fix it in your local queue before you push it again.
(Assignee)

Comment 14

4 years ago
Created attachment 767707 [details] [diff] [review]
patch

rebased
Attachment #765243 - Attachment is obsolete: true
(Assignee)

Comment 15

4 years ago
Created attachment 774146 [details] [diff] [review]
patch

Rebased

https://tbpl.mozilla.org/?tree=Try&rev=4e48e1903f13
Attachment #767707 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc1d6a5a4840
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cc1d6a5a4840
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.