885318 - Name collision with Promise

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Andrea Marchesini [:baku]]

devtools use a lot of Promise objects implemented in JS.
But bug 884279 renames Future to Promise and this makes a name collision.

Talking on IRC on #devtools, we found 2 possible solutions:

a) Rename Promise to JSPromise (or to something else)
b) do some destructuring assignment on import, like: let {resolve, reject, etc. } = Cu.import("promise.js");

Comment 2

[Joe Walker [:jwalker]]

In a separate thread we'd decided that we should be doing s/Promise/promise/g. Would this solve the problem?

Comment 3

[Andrea Marchesini [:baku]]

Yes, It does.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

I'll work on this.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Rename Promise to promise to avoid collisions with the forthcoming DOM Promise implementation

This turned out to be a lerger patch than I expected, due to us using lowercase promise as a local variable identifier. Maybe destructuring on import would have resulted in a shorter patch, but I don't know for sure or care. All tests pass locally.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=88c9960b5de1

Comment 7

[Joe Walker [:jwalker]]

Comment on attachment 773344 [details] [diff] [review]
Rename Promise to promise to avoid collisions with the forthcoming DOM Promise implementation

Review of attachment 773344 [details] [diff] [review]:
-----------------------------------------------------------------

It's kind of annoying that we can't call 'promise' 'promise' any more. Ho Hum.

Comment 8

[Masatoshi Kimura [:emk]]

How about migrating to DOM Promise?

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Masatoshi Kimura [:emk] from comment #8)
> How about migrating to DOM Promise?

This bug is a prerequisite for DOM Future to be renamed to Promise. We will likely migrate to that once its ready and has all the API methods we need.

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/d5a0afa466c2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d5a0afa466c2