Closed
Bug 884301
Opened 12 years ago
Closed 12 years ago
Remove "URL Protocol" from some non-protocol keys
Categories
(Thunderbird :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 25.0
People
(Reporter: emk, Assigned: emk)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
4.21 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
This patch depends on the m-c part of bug 883855.
Attachment #764132 -
Flags: review?(mbanner)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 764132 [details] [diff] [review]
patch
Looks fine, though I've not tested it. Thanks for the patch.
Attachment #764132 -
Flags: review?(mbanner) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Will c-c be reopened in future? Or do I have to ask an approval to land the fix forever?
|
|
Assignee | |
Comment 3•12 years ago
|
||
Bug 883855 has been landed. I would like to land this bug as soon as possible for consistency. How can I ask an approval? ("Flags" did not contain "approval‑comm‑central".)
|
|
Assignee | |
Updated•12 years ago
|
Flags: needinfo?(mbanner)
|
|
||
Comment 4•12 years ago
|
||
Generally people can ping me on irc for asking approval. However, here is also fine. I'd prefer this not to land at the moment, as our Windows builds are busted so we have no way of tracking if it causes a regression or not. The good news is releng are now working on bug 869974, so I'm hopeful this would be fixed later this week.
You can always use checkin-needed if you want to ensure that we don't forget it.
Flags: needinfo?(mbanner)
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
You need to log in
before you can comment on or make changes to this bug.
Description
•