884486 - [CBS] Channel message id 50 not being displayed in Lockscreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Michael Schwartz [:m4]]

https://bugzilla.mozilla.org/show_bug.cgi?id=828307 changed MCC in nsIDOMMozMobileNetworkInfo to string.  The change https://bugzilla.mozilla.org/show_bug.cgi?id=877751 uses the exact comparitor of that String MCC to the Number value defined in http://mxr.mozilla.org/gaia/source/apps/system/test/unit/mobile_operator_test.js#9.  The simple fix is to change the BRAZIL_MCC constant to a string.

Comment 1

[Michael Schwartz [:m4]]

Attachment: pull request

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 764432 [details]
pull request

looks good for me if mobileConnection.voice.network.mcc is always a string.

Comment 3

[Michael Schwartz [:m4]]

(In reply to Yuren Ju [:yurenju] from comment #2)
> looks good for me if mobileConnection.voice.network.mcc is always a string.

Yes, see the cited https://bugzilla.mozilla.org/show_bug.cgi?id=828307 for the why or check out the field definition http://mxr.mozilla.org/mozilla-b2g18/source/dom/network/interfaces/nsIDOMMobileConnection.idl#449

Comment 4

[Anthony Ricaud (:rik)]

Comment on attachment 764432 [details]
pull request

I'm good with the change but it breaks both the tests and the linter. See my comments in the PR.

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 764432 [details]
pull request

Lint and unit test failures need addressed

Comment 6

[Michael Schwartz [:m4]]

Attachment: Pull request

Addressed lint and test concerns

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 765084 [details]
Pull request

Great, thanks.

Comment 8

[Dale Harvey (:daleharvey)]

Sweet, merged in: https://github.com/mozilla-b2g/gaia/commit/56c50dd7b322a95a29882526eb00c9e261e43032

thanks

Comment 10

[Michael Schwartz [:m4]]

This bug affects all our release branches so needs to be uplifted to leo and tef.

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 56c50dd7b322a95a29882526eb00c9e261e43032 to:
v1-train: fbe8ffdbb4b37e845658d89877c701cb9903d162

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: fbe8ffdbb4b37e845658d89877c701cb9903d162

Comment 13

[Beatriz Rodríguez [:brg]]

According to comment 10 we need this patch in v1.0.1 to keep everything consistent.
can it be uplifted to v1.0.1?