[basket] [newsletter] trigger marketplace welcome email in right language & format

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: jdavis, Assigned: dpoirier)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Similar to Bug 874607, we need the Marketplace_FLG to trigger this welcome email:

marketplace_welcome

And fire it upon signup based on language & format (Note: at this time the Welcome emails is HTML only): 

en_marketplace_welcome
es_marketplace_welcome
pt_marketplace_welcome
pl_marketplace_welcome


I've updated basket prod and dev with this welcome email + newsletter and language information.

This needs to be in place to perfection by July 4th. I'm sorry for the last minute spec.

Please let me know if you have any questions.


The signup form for marketplace was put together here: Bug 874958
The go live signup form info is in: Bug 874932
(Assignee)

Comment 1

5 years ago
It sounds like we need to change two things from the default behavior, as an exception for this particular newsletter:

* Always send the welcome in HTML, regardless of the user's preference
* If their language preference is not es, pt, or pl, then send the en welcome?

Jess, can you confirm that?
Flags: needinfo?(jdavis)
(Assignee)

Comment 2

5 years ago
This makes me think of another interesting question - for the other newsletters, are the welcome messages available in every possible language?  Or just in the languages that the newsletter of that welcome supports? Or not even that?  Right now, the code just assumes a welcome is available in the user's preferred language, no matter what.
(Reporter)

Comment 3

5 years ago
(In reply to Dan Poirier [:dpoirier] from comment #1)
> It sounds like we need to change two things from the default behavior, as an
> exception for this particular newsletter:
> 
> * Always send the welcome in HTML, regardless of the user's preference
Actually - I'll have the text versions set up - it's just that most of these people will be new and their email pref will be set to HTML (or actually blank) by default. Long story.  If they're already in the system with the email format chosen, sending H vs. T is totally awesome.  No change needed here to the default behavior. (It's more how the form itself is set up.)

> * If their language preference is not es, pt, or pl, then send the en
> welcome?

Theoretically...the language should be set by which build of Marketplace they're using - and we're only showing the signup form to en, es, pt, or pl. Let me double check with the team in Bug 874932 to confirm this is true, and the default behavior to send the en version if we don't get a language explicitly set (aka they need to make sure the form explicitly sets the correct language).

> 
> Jess, can you confirm that?
Flags: needinfo?(jdavis)
(Reporter)

Comment 4

5 years ago
(In reply to Dan Poirier [:dpoirier] from comment #2)
> This makes me think of another interesting question - for the other
> newsletters, are the welcome messages available in every possible language? 
> Or just in the languages that the newsletter of that welcome supports? Or
> not even that?  Right now, the code just assumes a welcome is available in
> the user's preferred language, no matter what.

The welcome messages are only available in en - or the languages that are available for a particular newsletter.

about:mozilla - only en
apps & hacks - only en
Firefox & You - all newsletter languages
Marketplace - en, es, pt, pl


EN is always available for languages, and that should be the welcome sent if a language is not set. When we send the different language newsletters, if their language is en or blank - they get EN.  Likewise, if the newsletter is only available in en, they only get en.
(Assignee)

Comment 5

5 years ago
Okay, I'll need to add code to limit welcome messages to the same languages as their newsletters.  If Marketplace has its four languages configured in Basket, that'll cover Marketplace too.

And we won't do anything special for Marketplace with regard to format either. We'll assume welcomes are in place for whatever formats people are allowed to enter when they sign up.
(Reporter)

Comment 6

5 years ago
Perfect. Thanks Dan!
(Reporter)

Comment 7

5 years ago
(In reply to Dan Poirier [:dpoirier] from comment #5)
> Okay, I'll need to add code to limit welcome messages to the same languages
> as their newsletters.  If Marketplace has its four languages configured in
> Basket, that'll cover Marketplace too.
> 
Quick flag/complexity here: what if someone signs up for a en only newsletter and has es as their language set from Firefox & You? This brings up Bug 884958 and making sure that if the newsletter is en only, they get the en welcome email - even if their language was set to es (for another newsletter)
(Assignee)

Comment 8

5 years ago
For any single-language newsletter, we send the welcome email without a leading language code. That won't change with this bug.

I've opened this pull request for the changes:

https://github.com/mozilla/basket/pull/56
Status: NEW → ASSIGNED

Comment 9

5 years ago
Commit pushed to master at https://github.com/mozilla/basket

https://github.com/mozilla/basket/commit/2752376d46ee43c1d0b61a1f75f68b3fb08415aa
Bug 884598: Handle welcome languages correctly

We should only send a welcome message in a language
that its newsletter supports. Otherwise, use English.
(Reporter)

Updated

5 years ago
Blocks: 886565
(Reporter)

Comment 10

5 years ago
Tested and went live with today's push! :D
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.