884632 - Optimize MediaStreamGraphImpl::PrepareUpdatesToMainThreadState in order to only include AudioNodeStreams that the main thread is interested in

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

See bug 882543 comment 7 and 14.  Note that we need to send the updates for source nodes as well in order to keep the ended event working.

Comment 1

[(no longer active)]

This patch brings down the time to run the benchmark from about 40 seconds to about 16 seconds.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 764489 [details] [diff] [review]
Patch (v1)

Review of attachment 764489 [details] [diff] [review]:
-----------------------------------------------------------------

This is OK. However, can't AudioNodeStream::MainThreadNeedsUpdates specialize for SOURCE_STREAMs and only return true if the stream has ended?

Comment 3

[(no longer active)]

(In reply to comment #2)
> Comment on attachment 764489 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=764489
> Patch (v1)
> 
> Review of attachment 764489 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is OK. However, can't AudioNodeStream::MainThreadNeedsUpdates specialize
> for SOURCE_STREAMs and only return true if the stream has ended?

Yes, good idea.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/566ca9eb534e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/566ca9eb534e