884665 - Search by title and user in MakeEditor

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Brett Gaylor [:brett]]

Right now our phantom tagging solution is teh crazy. If we could search by title/user would be much faster and easier

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/92

Adds Title, Description and user search to the make Editor.

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 765450 [details] [review]
https://github.com/mozilla/MakeAPI/pull/92

R+

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/95d5ddbe1c0b6cc98dcf145073fc8eb2c374dd19
Fix Bug 884665 - Add Title, Description and username search to MakeEditor

Comment 6

[Kat Braybrooke [:codekat]]

um, if this is happening then AMAZING. YAYY! :)

Comment 7

[Brett Gaylor [:brett]]

Cade, could you push a build?  Would be really handy for content team so we can get better control of front page.

Comment 8

[Chris DeCairos (:cade)]

Pushing to Prod revealed that another patch broke consumers of the api using older NPM versions. we've backed it out of prod for those reasons.

I've bumped MakeAPI to v0.2.0 to reflect the API changes, and updated NPM.

I updated the node module in all the consuming apps ( Thimble, Popcorn Maker, Webmaker.org ) and tagged each. Staging is now running all the up to date versions.

On Monday, if you find everything's in order ( I tested publishing using PM and Thimble on staging, searching on WM.o-staging too, all working ), you can deploy to prod. 

The prod deploy might get a bit crazy, because we limit builds to 2. I suggest getting the makeAPI up, then Webmaker.org, then the apps. expect breakage in between, but once they're all up and the nodes are restarted, there shouldn't be any breakage.

We could also up the number of concurrent builds to try and get them all deployed as quickly as possible.

adding some need-Info's so this gets attention on Monday

Comment 9

[Brett Gaylor [:brett]]

I believe this has actually been pushed to prod - Chris?

Comment 10

[Matthew Schranz [:mjschranz]]

It should be Brett. MakeAPI Prod is at tag v0.1.28 and that tag includes this code.

Comment 11

[Jon Buckley [:jbuck]]

Yep, they're all deployed on prod right now.