884914 - Move hosted partner bundles into place automatically

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Chris Cooper [:coop] (he/him)]

Mozilla hosts a small subset of repacks due to contractual reasons. Someone from releng currently needs to move these repacks into place by hand. The instructions are pretty straightforward, so it seems like something we could automate easily:

https://intranet.mozilla.org/Build:Partners:Repacks:Bundles

Comment 1

[Mike Connor [:mconnor]]

This should probably be a higher priority, considering the manual build updates haven't been happening reliably.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Mike Connor [:mconnor] from comment #1)
> This should probably be a higher priority, considering the manual build
> updates haven't been happening reliably.

Agreed.

This can probably be implemented as an additional function of stage-tasks.py, which already does similar things. We'd need to support a 'partnerbundle' or similar in the args, and then write a method like https://github.com/mozilla/build-tools/blob/master/scripts/release/stage-tasks.py#L111, which does the work.

The only real question is where to store the list of file copies. Maybe it's OK to just hardcode it in stage-tasks.py, since we only have the one?

Comment 3

[Chris Cooper [:coop] (he/him)]

(In reply to Ben Hearsum [:bhearsum] from comment #2) 
> The only real question is where to store the list of file copies. Maybe it's
> OK to just hardcode it in stage-tasks.py, since we only have the one?

We actually have two, the docs are just crap. 

I'm updating the docs now so it will be trivial to script up after.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: add ability to sync partner bundles

This is just automation of https://wiki.mozilla.org/Release:Release_Automation_on_Mercurial:Updates_through_Shipping#Update_hosted_partner_bundles.

Need to adjust a couple of release configs, too.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: enable bundle syncing for firefox on mozilla-release

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 782678 [details] [diff] [review]
add ability to sync partner bundles

Review of attachment 782678 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/python/release/paths.py
@@ -10,5 @@
> -    # fennec/nightly
> -    if product == 'fennec':
> -        product = 'mobile'
> -        if not nightlyDir:
> -            nightlyDir = 'candidates'

This hunk will break Fennec, since productName is not "mobile" for it. Using stage_product would be better.

Comment 7

[[e-mail] (:bhearsum)]

Attachment: fix makeCandidatesDir regression

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 783729 [details] [diff] [review]
fix makeCandidatesDir regression

tests incoming

Comment 9

[Rail Aliiev [:rail]]

Attachment: tests

Comment 10

[[e-mail] (:bhearsum)]

Comment on attachment 782680 [details] [diff] [review]
enable bundle syncing for firefox on mozilla-release

I updated the real config too, since the release has already started.

Comment 11

[[e-mail] (:bhearsum)]

Landed, and I moved the FIREFOX_23_0_RELEASE tag so that this is picked up during its postrelease. I will be PTO at that time, Rail agreed to be on the hook in case something breaks.

Comment 12

[Hal Wine [:hwine] use NI!]

in production