Closed Bug 885148 Opened 6 years ago Closed 6 years ago

Commenting via patch details does not clear needinfo flag

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gkw, Assigned: dkl)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

In bug 883472 comment 13, I was set a needinfo flag.

-> usual way of action:
Comment, and the needinfo flag goes away automatically.

OR -> go to https://bugzilla.mozilla.org/attachment.cgi?id=765089&action=edit where I set feedback+ and commented, then submitted.

Comment appears in bug 883472 comment 15, but needinfo flag is not cleared automatically.

Should the flag be cleared in this case? I'd think so, but I'd defer to others here.
Component: User Interface → Extensions: Needinfo
verified.
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attached patch 885148_1.patchSplinter Review
- Added new hook to attachment/edit.html.tmpl 'after_comment_textarea' and the template in e/Needinfo/t/e/d/h/edit-after_comment_textarea.html.tmpl.
- Added needinfo.css stylesheet to combat the bold font-weight in attachment/edit.html.tmpl for <label> tags.
- Removed unused is_attachment attributes.

dkl
Attachment #8344740 - Flags: review?(glob)
Comment on attachment 8344740 [details] [diff] [review]
885148_1.patch

Review of attachment 8344740 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with hook/bug/show-header-end.html.tmpl to be deleted prior to commit.

::: extensions/Needinfo/template/en/default/hook/bug/show-header-end.html.tmpl
@@ +5,5 @@
> +  # This Source Code Form is "Incompatible With Secondary Licenses", as
> +  # defined by the Mozilla Public License, v. 2.0.
> +  #%]
> +
> +[% style_urls.push('extensions/Needinfo/web/styles/needinfo.css') %]

there's no need to include this fix on the show_bug page
Attachment #8344740 - Flags: review?(glob) → review+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
added extensions/Needinfo/web
modified extensions/Needinfo/template/en/default/hook/attachment/create-form_before_submit.html.tmpl
modified extensions/Needinfo/template/en/default/hook/attachment/edit-after_comment_textarea.html.tmpl
added extensions/Needinfo/template/en/default/hook/global/header-start.html.tmpl
added extensions/Needinfo/web/styles
added extensions/Needinfo/web/styles/needinfo.css
modified template/en/default/attachment/edit.html.tmpl
Committed revision 9177.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: Extensions: Needinfo → Extensions
You need to log in before you can comment on or make changes to this bug.