885294 - Immediate script selection from debugger search box is really janky and loses selection if you don't find anything

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[:Gijs (he/him)]

If I use the browser debugger, generally, script selection using the filter in the top right is really janky, because it seems to update the content view non-stop. This is very visually jarring. I don't think it should change until you hit enter, or until you actually start navigating the autocomplete list.

This is at its worst when I accidentally filter scripts rather than using 'find in this script', which makes me lose the script I had selected originally, meaning I have to re-filter to get back to it, and then do another search to do what I originally meant to do.

Comment 2

[Victor Porof [:vporof][:vp]]

A few alternative suggestions in https://bugzilla.mozilla.org/show_bug.cgi?id=945909#c0

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: dbg-no-auto-select.patch

When searching for files and functions, the first match isn't automatically selected anymore.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8355788 [details] [diff] [review]
dbg-no-auto-select.patch

Review of attachment 8355788 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 5

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/7f48035ecdb4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f48035ecdb4