881219 - When filtering sources, hiding items in the sources list is redundant

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Victor Porof [:vporof][:vp]]

Attachment: screenshot

While filtering files, as you type, a completion popup displaying all the matched sources is shown. At the same time, unmatched entries in the sources list on the left are hidden. This creates a redundant scenario in which matched sources are displayed in two places at the same time.

Example (STR):
1. Open debugger on http://todomvc.com/architecture-examples/backbone/
2. Type "to" in the filter box (without quotes)

Result: 4 matched files are shown both in the popup and the sources list.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: dbg-filter-redundant.patch

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: dbg-filter-redundant-tests.patch

Comment 3

[Victor Porof [:vporof][:vp]]

The amount dependent patches to test this out is pretty high. Get your builds from here: https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-fefd4e522879/

Try: https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 4

[Victor Porof [:vporof][:vp]]

Actual try link: https://tbpl.mozilla.org/?tree=Try&rev=fefd4e522879

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 801410 [details] [diff] [review]
dbg-filter-redundant.patch

Review of attachment 801410 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/debugger-toolbar.js
@@ +1278,3 @@
>  
> +    // Allow requests to settle down first.
> +    setNamedTimeout("sources-search", delay, () => this._doSearch(aToken));

eh?

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> Comment on attachment 801410 [details] [diff] [review]

Bug 891439.

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/ead76fb1a864
https://hg.mozilla.org/integration/fx-team/rev/47cc9c07b703

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ead76fb1a864
https://hg.mozilla.org/mozilla-central/rev/47cc9c07b703