Closed Bug 881219 Opened 8 years ago Closed 8 years ago

When filtering sources, hiding items in the sources list is redundant

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(3 files)

Attached image screenshot
While filtering files, as you type, a completion popup displaying all the matched sources is shown. At the same time, unmatched entries in the sources list on the left are hidden. This creates a redundant scenario in which matched sources are displayed in two places at the same time.

Example (STR):
1. Open debugger on http://todomvc.com/architecture-examples/backbone/
2. Type "to" in the filter box (without quotes)

Result: 4 matched files are shown both in the popup and the sources list.
Severity: normal → enhancement
Priority: -- → P3
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Blocks: 885294
Attachment #801410 - Flags: review?(rcampbell)
Attachment #801411 - Flags: review?(rcampbell)
Depends on: 886848, 876277, 891439
Blocks: 894311
Blocks: 876633
Comment on attachment 801410 [details] [diff] [review]
dbg-filter-redundant.patch

Review of attachment 801410 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/debugger-toolbar.js
@@ +1278,3 @@
>  
> +    // Allow requests to settle down first.
> +    setNamedTimeout("sources-search", delay, () => this._doSearch(aToken));

eh?
Attachment #801410 - Flags: review?(rcampbell) → review+
Attachment #801411 - Flags: review?(rcampbell) → review+
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> Comment on attachment 801410 [details] [diff] [review]

Bug 891439.
https://hg.mozilla.org/mozilla-central/rev/ead76fb1a864
https://hg.mozilla.org/mozilla-central/rev/47cc9c07b703
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.