885319 - Implement the immersive process check in DownloadIntegration

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[:Paolo Amadini]

The DownloadIntegration._isImmersiveProcess method should be implemented, to
allow using the getTemporaryDownloadsDirectory function on Windows.

This is a Windows system call that can be implemented using js-ctypes.

Comment 1

[Jim Mathies [:jimm]]

(In reply to Paolo Amadini [:paolo] from comment #0)
> The DownloadIntegration._isImmersiveProcess method should be implemented, to
> allow using the getTemporaryDownloadsDirectory function on Windows.
> 
> This is a Windows system call that can be implemented using js-ctypes.

You can use metro utils for this if you like - 

http://mxr.mozilla.org/mozilla-central/source/widget/nsIWinMetroUtils.idl

if that exists, can be created, and immersive returns true, you're running in metro land.

Comment 2

[:Paolo Amadini]

(In reply to Jim Mathies [:jimm] from comment #1)
> You can use metro utils for this if you like - 

Ah, thanks a lot! I didn't find this in my search before.

So this task turns from easy to trivial (as long as development is done on a
Windows 8 machine).

Comment 3

[:Paolo Amadini]

Given that we'd like the Downloads.jsm directories API to work in Firefox 26, even if initially unused, we should remove the _isImmersiveProcess stub and replace it with a simple check for:

  Services.metro && Services.metro.immersive

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=ef618eb57a29 (Aurora)
https://tbpl.mozilla.org/?tree=Try&rev=e9af0b57eb21 (Central)

Comment 5

[:Paolo Amadini]

Comment on attachment 820897 [details] [diff] [review]
v1

Can you remove _isImmersiveProcess? I don't think we need a helper for that anymore.

Comment 6

[Raymond Lee [:raymondlee]]

Attachment: bug-885319-v2.diff

Comment 7

[:Paolo Amadini]

Comment on attachment 821439 [details] [diff] [review]
bug-885319-v2.diff

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 825588
User impact if declined: None (related to bug 926736)
Testing completed (on m-c, etc.): None (possible add-on only code path)
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 8

[:Paolo Amadini]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ea44c93520ab

Comment 9

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/02b75478ab47

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/02b75478ab47