929391 - Use Downloads.getTemporaryDownloadsDirectory instead of GetDownloadDirectory in nsHelperAppService.cpp

Status: NEW

(Toolkit :: Downloads API, task, P3)

Description

[:Paolo Amadini]

While this doesn't prevent us from decommissioning nsIDownloadManager, using Downloads.getTemporaryDownloadsDirectory instead of GetDownloadDirectory in nsHelperAppService.cpp will help in unifying the code paths.

We will need an XPCOM call to be able to use the function.

Comment 1

[Ganesh Sahukari]

i would like to work on this bug. Can you assign me the bug

Comment 2

[Marco Bonardo [:mak]]

I wonder if paolo planned to mentor this bug

Comment 3

[:Paolo Amadini]

Yeah, glad to mentor!

Good choice Ganesh, as this builds upon the IDL skills. Since we want to remove nsIDownloadManager and nsDownloadManager.cpp from the tree, we'll need a new interface and component located in the "jsdownloads" folder. This will allow the getTemporaryDownloadsDirectory function to be called indirectly from C++. The component would be JavaScript-implemented, the reverse of the nsIDebug2 case. DownloadLegacy.js implementing nsITransfer is an example of this.

For simplicity on the C++ side, the IDL interface would be callback-based, while Downloads.getTemporaryDownloadsDirectory is Promise-based. mozIAsyncHistory.isURIVisited and mozIVisitedStatusCallback are examples of this callback-based pattern.

Feel free to start by taking a look at the code, and let me know if you have any questions!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mak, could you have a look please?
For more information, please visit auto_nag documentation.