Closed Bug 885357 Opened 7 years ago Closed 7 years ago

Migrate "plugins.click_to_play" pref to "plugin.default.state" on upgrade

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 24
Tracking Status
firefox24 --- verified
fennec 24+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

The gecko pref that corresponds to click to play settings has changed. This was updated in bug 884694, but it would be good to migrate any user-set prefs.

onAppUpdated seems like the right place to do this, but I think we'd want to start passing a version number to that, so that we only do this once.
tracking-fennec: ? → 24+
Benjamin, Margaret tells me that this is a follow up from a patch you landed.
Assignee: nobody → benjamin
This is, but I'm not sure if there's anything else to do other than read click_to_play and set .default.state to the matching value...
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> This is, but I'm not sure if there's anything else to do other than read
> click_to_play and set .default.state to the matching value...

Well, we need to write a patch :) I can just take this bug, since I'm more familiar with how to do that in Fennec.
Assignee: benjamin → margaret.leibovic
Attached patch patchSplinter Review
Attachment #765608 - Flags: review?(wjohnston)
Attachment #765608 - Flags: feedback?(benjamin)
Comment on attachment 765608 [details] [diff] [review]
patch

Review of attachment 765608 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine.
Attachment #765608 - Flags: review?(wjohnston) → review+
Attachment #765608 - Flags: feedback?(benjamin)
https://hg.mozilla.org/mozilla-central/rev/0a7b5696c49a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.