885615 - JavaScript Warning: "reference to undefined property exn.stack" {file: "resource://gre/modules/osfile/osfile_async_worker.js" line: 55

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[Chris Peterson [:cpeterson]]

I see the following JS warning logged almost every time I open the about:config page in Firefox for Android:

E/GeckoConsole(14503): [JavaScript Warning: "reference to undefined property exn.stack" {file: "resource://gre/modules/osfile/osfile_async_worker.js" line: 55}]

`exn` does not have a `stack` property because it is the string "Unix error 2 during operation open (No such file or directory)", not an `Error` object.

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Attachment: Patch v1

I'm seeing a similar issue on Windows. Every time I start Firefox I get this in my console:
  reference to undefined property exn.stack

The attached patch seemed to fix the issue. Another approach might be to find out where we're throwing the exception that lacks a 'stack' property.

Comment 2

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

https://hg.mozilla.org/integration/fx-team/rev/46df1731dffc

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 793145 [details] [diff] [review]
Patch v1

This patch caused mochitest-other orange and was backed out in changeset e453f69bc437

This is probably better as a mentored bug anyway, so I'll unassign myself

Comment 4

[Daniel Holbert [:dholbert]]

I think we need to prioritize this; this has the capability to mess up test logs.

I just had a (local) reftest log rejected by reftest-analyzer, because this bug's message was printed in the middle of my test output.  In particular, the relevant log line started like so:
> reference to undefined property options.bytesREFTEST TEST-UNEXPECTED-FAIL |  file:///[...]

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Well, the line you mention is fixed by bug 910300.

Comment 6

[Daniel Holbert [:dholbert]]

oops. wrong bug, sorry! :)

Comment 7

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-osfile-error

This was bugging me today. This patch passes the test that the other patch didn't pass.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 811447 [details] [diff] [review]
fix-osfile-error

Review of attachment 811447 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cac1d22b204

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1cac1d22b204