885642 - avoid iterating SVG text frames when they are dirty, with svg.text.css-frames.enabled

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

In case we miss reflowing our SVG text frames, we should just make the TextFrameIterator pretend there are no frames there.  That will avoid relying on the outdated text node correspondence information.

Comment 1

[Cameron McCormack (:heycam)]

This assertion gets triggered by layout/reftests/bidi/bidiSVG-03.svg, it seems.

Comment 2

[Cameron McCormack (:heycam)]

And by any use of SVG text.

Testing a new patch: https://tbpl.mozilla.org/?tree=Try&rev=67d83808afbf

Comment 3

[Cameron McCormack (:heycam)]

Attachment: patch v2

Updated patch.  Now instead of doing the check in TextFrameIterator, we do it in TextRenderedRunIterator and CharIterator.  This is because UpdateFontSizeScaleFactor uses TextFrameIterator (but doesn't care about the correspondence with the content nodes) to look at the font sizes in use, and it does this after the anonymous kid is reflowed but before the remainder of ReflowSVG is done (which is where the dirty state bits are cleared).

Comment 4

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c95c50bae8db

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c95c50bae8db