885820 - Port Flue from Flask to Express (python to node)

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Matt Basta [:basta]]

This will mean that we can run a local instance of Flue on Travis CI instead of using FaaS on stackato for tests. Let me list all the ways that this is good:

1. Updating Flue's source doesn't mean the tests are going to break until Basta updates stackato
2. `npm install -d` will grab the pieces that are needed for Flue
3. Less Python code to support JavaScript code

Comment 1

[Christopher Van Wiemeersch [:cvan]]

You could totally do this without Express even - but I know how much you <3 dependencies ;)

Comment 2

[Matt Basta [:basta]]

I thought about using raw HTTP, but the URL routing is something I don't care to write from scratch :P

Comment 3

[Christopher Van Wiemeersch [:cvan]]

P3? This seems arguably less important than a P3.

Comment 4

[Matt Basta [:basta]]

It's P3 because our tests sporadically fail because of it.

Comment 5

[Kevin Ngo [:ngoke]]

Putting myself off of this for now, managed a WIP start. https://github.com/ngokevin/flue/tree/powerflue

Comment 6

[Andy McKay]

If you want to do this please reopen.

Comment 7

[Mathieu Pillard [:mat]]

Re-opening. I don't know if that's the solution we need (maybe a simpler mock would work), but my experience matches comment 4, a large share of the intermittent failures we are seeing with the fireplace tests come from problems reaching flue. This is annoying and time-consuming.

Comment 8

[Mathieu Pillard [:mat]]

Another (simpler?) option would be to manage to build and run flue locally on Travis. We do that for elasticsearch in zamboni.

Comment 9

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/fireplace/commit/cbe2f8bbb537e0b8818a820a59242c846f2c4b72

This is now running locally on Travis. We still see some intermittent failures so there's still work to do there.